fix: remove asserts from risc0 and sp1 (#557)

Co-authored-by: Mariano A. Nicolini <mariano.nicolini.91@gmail.com>

Author: NicolasRampoldi

operator/risc_zero/lib/src/lib.rs

@@ -7,15 +7,13 @@ pub extern "C" fn verify_risc_zero_receipt_ffi(
     image_id: *const u8,
     image_id_len: u32,
 ) -> bool {
-    let receipt_bytes = unsafe {
-        assert!(!receipt_bytes.is_null());
-        std::slice::from_raw_parts(receipt_bytes, receipt_len as usize)
-    };
+    if receipt_bytes.is_null() || image_id.is_null() {
+        return false;
+    }
+
+    let receipt_bytes = unsafe { std::slice::from_raw_parts(receipt_bytes, receipt_len as usize) };
 
-    let image_id = unsafe {
-        assert!(!image_id.is_null());
-        std::slice::from_raw_parts(image_id, image_id_len as usize)
-    };
+    let image_id = unsafe { std::slice::from_raw_parts(image_id, image_id_len as usize) };
 
     let mut image_id_array = [0u8; 32];
     image_id_array.copy_from_slice(image_id);
@@ -31,7 +29,9 @@ mod tests {
     use super::*;
 
     const RECEIPT: &[u8] = include_bytes!("../../../../scripts/test_files/risc_zero/fibonacci_proof_generator/risc_zero_fibonacci.proof");
-    const IMAGE_ID: &[u8] = include_bytes!("../../../../scripts/test_files/risc_zero/fibonacci_proof_generator/fibonacci_id.bin");
+    const IMAGE_ID: &[u8] = include_bytes!(
+        "../../../../scripts/test_files/risc_zero/fibonacci_proof_generator/fibonacci_id.bin"
+    );
 
     #[test]
     fn verify_risc_zero_receipt_with_image_id_works() {

operator/sp1/lib/src/lib.rs

@@ -1,6 +1,6 @@
-use std::slice;
-use sp1_sdk::ProverClient;
 use lazy_static::lazy_static;
+use sp1_sdk::ProverClient;
+use std::slice;
 
 lazy_static! {
     static ref PROVER_CLIENT: ProverClient = ProverClient::new();
@@ -13,15 +13,13 @@ pub extern "C" fn verify_sp1_proof_ffi(
     elf_bytes: *const u8,
     elf_len: u32,
 ) -> bool {
-    let proof_bytes = unsafe {
-        assert!(!proof_bytes.is_null());
-        slice::from_raw_parts(proof_bytes, proof_len as usize)
-    };
+    if proof_bytes.is_null() || elf_bytes.is_null() {
+        return false;
+    }
+
+    let proof_bytes = unsafe { slice::from_raw_parts(proof_bytes, proof_len as usize) };
 
-    let elf_bytes = unsafe {
-        assert!(!elf_bytes.is_null());
-        slice::from_raw_parts(elf_bytes, elf_len as usize)
-    };
+    let elf_bytes = unsafe { slice::from_raw_parts(elf_bytes, elf_len as usize) };
 
     if let Ok(proof) = bincode::deserialize(proof_bytes) {
         let (_pk, vk) = PROVER_CLIENT.setup(elf_bytes);
@@ -35,17 +33,16 @@ pub extern "C" fn verify_sp1_proof_ffi(
 mod tests {
     use super::*;
 
-    const PROOF: &[u8] =
-        include_bytes!("../../../../scripts/test_files/sp1/sp1_fibonacci.proof");
-    const ELF: &[u8] =
-        include_bytes!("../../../../scripts/test_files/sp1/sp1_fibonacci.elf");
+    const PROOF: &[u8] = include_bytes!("../../../../scripts/test_files/sp1/sp1_fibonacci.proof");
+    const ELF: &[u8] = include_bytes!("../../../../scripts/test_files/sp1/sp1_fibonacci.elf");
 
     #[test]
     fn verify_sp1_proof_with_elf_works() {
         let proof_bytes = PROOF.as_ptr();
         let elf_bytes = ELF.as_ptr();
 
-        let result = verify_sp1_proof_ffi(proof_bytes, PROOF.len() as u32, elf_bytes, ELF.len() as u32);
+        let result =
+            verify_sp1_proof_ffi(proof_bytes, PROOF.len() as u32, elf_bytes, ELF.len() as u32);
         assert!(result)
     }
 
@@ -54,7 +51,12 @@ mod tests {
         let proof_bytes = PROOF.as_ptr();
         let elf_bytes = ELF.as_ptr();
 
-        let result = verify_sp1_proof_ffi(proof_bytes, (PROOF.len() - 1) as u32, elf_bytes, ELF.len() as u32);
+        let result = verify_sp1_proof_ffi(
+            proof_bytes,
+            (PROOF.len() - 1) as u32,
+            elf_bytes,
+            ELF.len() as u32,
+        );
         assert!(!result)
     }
 }