ci: add a ci to compile and lint the batcher libs (#676)

Author: NicolasRampoldi

.github/workflows/build.yml .github/workflows/build-go.yml.github/workflows/build.yml renamed to .github/workflows/build-go.yml

@@ -0,0 +1,44 @@
+name: build-rust-projects
+
+on:
+  merge_group:
+  push:
+    branches: [main]
+  pull_request:
+    branches: ["*"]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          components: rustfmt, clippy
+          override: true
+      - name: Cache Rust dependencies
+        uses: actions/cache@v3
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            batcher/target
+          key: ${{ runner.os }}-rust-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-rust-
+      - name: Check formatting of Rust projects
+        run: |
+          cd batcher
+          cargo fmt --all -- --check
+      - name: Run Clippy
+        run: |
+          cd batcher
+          cargo clippy --all -- -D warnings
+      - name: Build Rust projects
+        run: |
+          cd batcher
+          cargo build --all

.github/workflows/build-rust.yml

@@ -217,9 +217,8 @@ impl Batcher {
         if let Ok(addr) = client_msg.verify_signature() {
             info!("Message signature verified");
             if self.is_nonpaying(&addr) {
-                return self
-                    .handle_nonpaying_msg(ws_conn_sink.clone(), client_msg)
-                    .await;
+                self.handle_nonpaying_msg(ws_conn_sink.clone(), client_msg)
+                    .await
             } else {
                 if !self.check_user_balance(&addr).await {
                     send_message(
@@ -267,7 +266,7 @@ impl Batcher {
                 info!("Verification data message handled");
 
                 send_message(ws_conn_sink, ValidityResponseMessage::Valid).await;
-                return Ok(());
+                Ok(())
             }
         } else {
             error!("Signature verification error");
@@ -284,7 +283,7 @@ impl Batcher {
     // If user has sufficient balance, increments the user's proof count in the batch
     async fn check_user_balance(&self, addr: &Address) -> bool {
         let mut user_proof_counts = self.user_proof_count_in_batch.lock().await;
-        let user_proofs_in_batch = user_proof_counts.get(addr).unwrap_or(&0).clone() + 1;
+        let user_proofs_in_batch = *user_proof_counts.get(addr).unwrap_or(&0) + 1;
 
         let user_balance = self.get_user_balance(addr).await;
 

batcher/aligned-batcher/src/lib.rs

@@ -30,13 +30,12 @@ pub async fn send_messages(
     ws_write: Arc<Mutex<SplitSink<WebSocketStream<MaybeTlsStream<TcpStream>>, Message>>>,
     verification_data: &[VerificationData],
     wallet: Wallet<SigningKey>,
-    nonce: U256,
+    mut nonce: U256,
 ) -> Result<Vec<NoncedVerificationData>, SubmitError> {
     let mut sent_verification_data = Vec::new();
 
     let mut ws_write = ws_write.lock().await;
 
-    let mut nonce = nonce.clone();
     let mut nonce_bytes = [0u8; 32];
 
     let mut response_stream = response_stream.lock().await;

batcher/aligned-sdk/src/communication/messaging.rs

@@ -324,10 +324,9 @@ async fn main() -> Result<(), AlignedError> {
                     unique_batch_merkle_roots.insert(aligned_verification_data.batch_merkle_root);
                 }
 
-                if unique_batch_merkle_roots.len() > 1 {
-                    info!("Proofs submitted to aligned. See the batches in the explorer:");
-                } else if unique_batch_merkle_roots.len() == 1 {
-                    info!("Proofs submitted to aligned. See the batch in the explorer:");
+                match unique_batch_merkle_roots.len() {
+                    1 => info!("Proofs submitted to aligned. See the batch in the explorer:"),
+                    _ => info!("Proofs submitted to aligned. See the batches in the explorer:"),
                 }
 
                 for batch_merkle_root in unique_batch_merkle_roots {