Rename dialect function

Author: yoavcloud

src/dialect/mod.rs

@@ -1223,7 +1223,7 @@ pub trait Dialect: Debug + Any {
     }
 
     /// Returns true if the dialect considers the `&&` operator as a boolean AND operator.
-    fn supports_overlap_as_and_operator(&self) -> bool {
+    fn supports_double_ampersand_operator(&self) -> bool {
         false
     }
 }

src/dialect/mysql.rs

@@ -173,7 +173,7 @@ impl Dialect for MySqlDialect {
     }
 
     /// See: <https://dev.mysql.com/doc/refman/8.4/en/expressions.html>
-    fn supports_overlap_as_and_operator(&self) -> bool {
+    fn supports_double_ampersand_operator(&self) -> bool {
         true
     }
 }

src/parser/mod.rs

@@ -3500,7 +3500,7 @@ impl<'a> Parser<'a> {
             Token::Overlap if dialect_is!(dialect is PostgreSqlDialect | GenericDialect) => {
                 Some(BinaryOperator::PGOverlap)
             }
-            Token::Overlap if dialect.supports_overlap_as_and_operator() => {
+            Token::Overlap if dialect.supports_double_ampersand_operator() => {
                 Some(BinaryOperator::And)
             }
             Token::CaretAt if dialect_is!(dialect is PostgreSqlDialect | GenericDialect) => {

tests/sqlparser_common.rs

@@ -18040,6 +18040,6 @@ fn parse_select_parenthesized_wildcard() {
 
 #[test]
 fn parse_overlap_as_bool_and() {
-    let dialects = all_dialects_where(|d| d.supports_overlap_as_and_operator());
+    let dialects = all_dialects_where(|d| d.supports_double_ampersand_operator());
     dialects.one_statement_parses_to("SELECT x && y", "SELECT x AND y");
 }