fix: fix method snippets for classes with implicit constructor and functions within constructor arguments e.g. new A(foo())

Author: zardoy

typescript/src/constructMethodSnippet.ts

@@ -26,7 +26,9 @@ export default (
     if (ts.isIdentifier(containerNode)) containerNode = containerNode.parent
     if (ts.isPropertyAccessExpression(containerNode)) containerNode = containerNode.parent
 
-    const isNewExpression = ts.isNewExpression(containerNode)
+    const isNewExpression =
+        ts.isNewExpression(containerNode) &&
+        ts.textSpanIntersectsWithPosition(ts.createTextSpanFromBounds(containerNode.expression.pos, containerNode.expression.end), position)
     if (!isNewExpression && (type.getProperties().length > 0 || type.getStringIndexType() || type.getNumberIndexType())) {
         resolveData.isAmbiguous = true
     }
@@ -36,7 +38,7 @@ export default (
     if (signatures.length === 0) return
     const signature = signatures[0]!
     // probably need to remove check as class can be instantiated inside another class, and don't really see a reason for this check
-    if (isNewExpression && hasPrivateOrProtectedModifier((signature.getDeclaration() as ts.ConstructorDeclaration).modifiers)) return
+    if (isNewExpression && hasPrivateOrProtectedModifier((signature.getDeclaration() as ts.ConstructorDeclaration | undefined)?.modifiers)) return
     if (signatures.length > 1 && c('methodSnippets.multipleSignatures') === 'empty') {
         return ['']
     }

typescript/test/completions.spec.ts

@@ -137,6 +137,9 @@ describe('Method snippets', () => {
             function foo(this: {}) {}
             foo/*3*/
 
+            // new class
+            new Something(foo/*301*/)
+
             // contextual type
             declare const bar: {
                 b: (a) => {}
@@ -173,6 +176,7 @@ describe('Method snippets', () => {
         compareMethodSnippetAgainstMarker(markers, 1, null)
         compareMethodSnippetAgainstMarker(markers, 2, '()')
         compareMethodSnippetAgainstMarker(markers, 3, '(a)')
+        compareMethodSnippetAgainstMarker(markers, 301, '(a)')
         compareMethodSnippetAgainstMarker(markers, 4, '($b)')
         compareMethodSnippetAgainstMarker(markers, 5, '(a, b, { d, e: {} }, ...c)')
         compareMethodSnippetAgainstMarker(markers, 6, '(a, b, c)')
@@ -188,13 +192,17 @@ describe('Method snippets', () => {
                 protected constructor(a) {}
             }
 
+            class C {}
+
             new A/*1*/
             // not sure...
             new B/*2*/
+            new C/*3*/
         `)
 
         compareMethodSnippetAgainstMarker(markers, 1, ['a'])
         compareMethodSnippetAgainstMarker(markers, 2, null)
+        compareMethodSnippetAgainstMarker(markers, 3, [])
     })
 
     test('Skip trailing void', () => {