fix: Fix the wrong result of not_contain_compare when source_value is a list#5152
Conversation
# Conflicts: # apps/application/flow/step_node/tool_lib_node/impl/base_tool_lib_node.py
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| chat_model = get_model_instance_by_model_workspace_id(model_id, workspace_id, | ||
| **( | ||
| model_params_setting or {})) if model_id is not None else None | ||
| **(model_params_setting or {})) if model_id is not None else None |
| if isinstance(source_value, str): | ||
| return str(target_value) not in source_value | ||
| elif isinstance(self, list): | ||
| elif isinstance(source_value, list): |
| value = 0 if ['0', '[]'].__contains__(value) else value | ||
| if isinstance(value, str) and value.lower() in ('false', '0', '[]', ''): | ||
| return False | ||
| return bool(value) |
There was a problem hiding this comment.
修复当 value 为字符串 false 时，bool(value) 返回了 True 的问题。
注：后面多处代码相同处理。
| get_knowledge_operation_object(keywords.get('knowledge_id')), | ||
| get_knowledge_operation_object(keywords.get('knowledge_id')), | ||
| get_document_operation_object(keywords.get('document_id')) | ||
| ), |
There was a problem hiding this comment.
get_knowledge_document_operation_object 方法只有两个参数，这里多传了一个。
感觉应该是不小心多复制了一行代码。
| from trigger.handler.impl.task.tool_task import ToolTask | ||
|
|
||
| ToolTask.execute(trigger_task, **kwargs) | ||
| ToolTask().execute(trigger_task, **kwargs) |
There was a problem hiding this comment.
ApplicationTask 和 ToolTask 是 class，必须先实例化才能调用方法。
估计是漏写了。
2 participants
What this PR does / why we need it?
fix: Fix the wrong result of
not_contain_comparewhensource_valueis a listSummary of your change
修复 当
source_value是 list 类型时，not_contain_compare的判断结果错误的问题顺便修复一些语法错误。
Please indicate you've done the following: