Merged
Conversation
Restrict scope to reduce what is visible to consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
Target Framework Updates:
Updated the target frameworks from .NET 9.0 to .NET 8.0; .NET 9.0 for broader compatibility.
Dependency Updates:
Microsoft.Build: Downgraded from version 17.13.9 to 17.11.4 to support net8.0
Code Modifications:
Changed method access modifiers in MermaidDiagram.cs and its derived classes:
Header method updated from public to internal for more restrictive access.
Marked ToString method as sealed override to prevent further overrides.
Refactored logic for determining TargetFramework in ClassDiagram.cs:
Added fallback to TargetFrameworks when TargetFramework is empty.
Testing Enhancements:
Improved test assertions in CommandsTests.cs to validate graph content includes the diagram title.
Removed redundant test case Header_ShouldInitializeGraphWithTitle from MermaidDiagramTests.cs.
Documentation Updates:
Updated README.md to reflect changes in target frameworks and dependencies.
Closes #8