Conversation
wang2yn84
approved these changes
Mar 17, 2025
Contributor
wang2yn84
left a comment
wang2yn84
left a comment
There was a problem hiding this comment.
Thank you very much for the fix. Lgtm with some minor questions.
| - [Inference](#inference) | ||
| - [Flux](#flux) | ||
| - [Flash Attention for GPU:](#flash-attention-for-gpu) | ||
| - [Fused Attention for GPU:](#fused-attention-for-gpu) |
Contributor
There was a problem hiding this comment.
Is there any reason why we name it as fused attention instead of flash attention considering you are using cudnn_flash_te?
|
|
||
| ```bash | ||
| NVTE_FUSED_ATTN=1 python -m src.maxdiffusion.train_sdxl src/maxdiffusion/configs/base_xl.yml hardware=gpu run_name='test-sdxl-train' output_dir=/tmp/ train_new_unet=true train_text_encoder=false cache_latents_text_encoder_outputs=true max_train_steps=200 weights_dtype=bfloat16 resolution=512 per_device_batch_size=1 attention="cudnn_flash_te" jit_initializers=False | ||
| ``` |
Contributor
There was a problem hiding this comment.
Consider jit initializer works, maybe remove this config?
Contributor
|
Since we are only using TF and Pytorch on CPU only, shall we install the tf[cpu] and pytorch[cpu] instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.