Remove noop spmd_mode check, correct type annotations in attention flax#170
Closed
Remove noop spmd_mode check, correct type annotations in attention flax#170
Conversation
Signed-off-by: Kunjan patel <kunjanp@google.com>
Signed-off-by: Kunjan patel <kunjanp@google.com>
entrpn
approved these changes
May 2, 2025
Collaborator
Author
|
Not needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
AttentionOp'sscaleparam type to float, since it is passed as float to subsequent DotProductAttention callswith jax.spmd_mode("allow_all"):