Add the unipc multistep scheduler.#174
Merged
entrpn merged 4 commits intoAI-Hypercomputer:mainfrom May 20, 2025
Merged
Conversation
entrpn
reviewed
May 19, 2025
entrpn
reviewed
May 19, 2025
Collaborator
There was a problem hiding this comment.
can you add a license to this file:
"""
Copyright 2025 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""
entrpn
approved these changes
May 20, 2025
hx89
pushed a commit
to hx89/maxdiffusion
that referenced
this pull request
May 28, 2025
* Add the unipc multistep scheduler. * Add unit tests to the unipc multistep scheduler. * Add an __init__.py to the test directory * Add license to init file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference pytorch implementation: https://github.com/huggingface/diffusers/blob/main/src/diffusers/schedulers/scheduling_unipc_multistep.py
Tested with running the denoising loop with both the jax and pytorch implementation and compared outputs. Tests files: qinyiyan@f4bb315