Bug fixes and performance optimizations for FLUX training#187
Merged
coolkp merged 2 commits intoAI-Hypercomputer:mainfrom Jul 16, 2025
Merged
Bug fixes and performance optimizations for FLUX training#187coolkp merged 2 commits intoAI-Hypercomputer:mainfrom
coolkp merged 2 commits intoAI-Hypercomputer:mainfrom
Conversation
Collaborator
|
Can you git rebase instead of merge to preserve the commit history? |
coolkp
reviewed
Jul 15, 2025
|
|
||
| from google.cloud import storage | ||
|
|
||
| libcudart = cdll.LoadLibrary("libcudart.so") |
Collaborator
There was a problem hiding this comment.
This is breaking the pytest, the pytest workflow right now only supports TPU. The dependencies are not installed. https://github.com/AI-Hypercomputer/maxdiffusion/blob/eaef265428ef200f8260e4edb017f0b59e839f1b/.github/workflows/UnitTests.yml
Contributor
Author
There was a problem hiding this comment.
I have removed nsys and rebased to main.
hx89
force-pushed
the
haixinl/sharding_fix
branch
from
3516f7b to
282f741
Compare
hx89
force-pushed
the
haixinl/sharding_fix
branch
from
282f741 to
105b8fe
Compare
coolkp
approved these changes
Jul 16, 2025
Collaborator
coolkp
left a comment
coolkp
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes:
Performance optimizations:
Also added nsys profiler support