Skip to content

Remove mlperf logging #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
entrpn merged 2 commits into from
Jul 18, 2025
Merged

Remove mlperf logging #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fa0fb4
Remove mlperf logging
coolkp Jul 18, 2025
9ce2c6c
Try out posting xlml test link in PR
coolkp Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-miniconda/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ inputs:
description: If set to any value, dont use sudo to clean the workspace
required: false
type: string
default: "3.9"
default: "3.10"
miniconda-version:
description: Miniconda version to install
required: false
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/XLML.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Add Testgrid Link to PR

on:
pull_request:
types: [opened, synchronize]

jobs:
add_testgrid_link:
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- name: Add link to PR description
env:
PR_NUMBER: ${{ github.event.pull_request.number }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
curl -X POST \
-H "Authorization: token $GITHUB_TOKEN" \
-H "Accept: application/vnd.github.v3+json" \
"https://api.github.com/repos/${{ github.repository }}/issues/$PR_NUMBER/comments" \
-d '{ "body": "e2e testgrid: https://8bcf50593faf4ea38060e236169827e5-dot-us-central1.composer.googleusercontent.com/dags/maxdiffusion_tpu_e2e/grid" }'
106 changes: 0 additions & 106 deletions src/maxdiffusion/mllog_utils.py
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/maxdiffusion/train_flux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from maxdiffusion import (
max_logging,
pyconfig,
mllog_utils,
)

from maxdiffusion.train_utils import (
Expand All @@ -39,7 +38,6 @@ def train(config):
def main(argv: Sequence[str]) -> None:
pyconfig.initialize(argv)
config = pyconfig.config
mllog_utils.train_init_start(config)
validate_train_config(config)
max_logging.log(f"Found {jax.device_count()} devices.")
train(config)
Expand Down
2 changes: 0 additions & 2 deletions src/maxdiffusion/train_sdxl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from maxdiffusion import (
max_logging,
pyconfig,
mllog_utils,
)

from maxdiffusion.trainers.sdxl_trainer import StableDiffusionXLTrainer
Expand All @@ -39,7 +38,6 @@ def train(config):
def main(argv: Sequence[str]) -> None:
pyconfig.initialize(argv)
config = pyconfig.config
mllog_utils.train_init_start(config)
validate_train_config(config)
max_logging.log(f"Found {jax.device_count()} devices.")
train(config)
Expand Down
Loading