Conversation
coolkp
reviewed
Aug 11, 2025
Collaborator
|
Do we need requirements.txt update? |
coolkp
reviewed
Aug 11, 2025
coolkp
reviewed
Aug 11, 2025
Collaborator
|
Can we also add a unit test to verify the quantization logic. Doesn't need to load the full model. |
Collaborator
Author
Yes. Just added it. |
Collaborator
Author
Have added three unit test on qwix quantization logic. |
entrpn
approved these changes
Aug 12, 2025
coolkp
reviewed
Aug 12, 2025
coolkp
approved these changes
Aug 12, 2025
Collaborator
|
I manually tested on runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use qwix to quantize the WAN transformer
Add parameters:
When applying qwix quantization, please set parameters by: use_qwix_quantization=True quantization="fp8_full"