Conversation
Collaborator
entrpn
commented
Aug 14, 2025
entrpn
commented
- Fix cross attention padding in splash attention
- Add option to replicate vae.
coolkp
previously approved these changes
Aug 14, 2025
coolkp
approved these changes
Aug 15, 2025
coolkp
reviewed
Aug 15, 2025
| config_fp8.quantization = "fp8" | ||
| provider_fp8 = WanPipeline.get_qt_provider(config_fp8) | ||
| self.assertIsNotNone(provider_fp8) | ||
| mock_qt_rule.assert_called_once_with( |
Collaborator
There was a problem hiding this comment.
we don't want to undo this change, sanbao fixed the test earlier. There is no attributes rules so was breaking the test.
coolkp
reviewed
Aug 15, 2025
| act_qtype=jnp.float8_e4m3fn, | ||
| bwd_qtype=jnp.float8_e5m2, | ||
| bwd_use_original_residuals=True, | ||
| disable_channelwise_axes=True, # per_tensor calibration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.