Conversation
3a89142 to
e02ac9c
Compare
…and fix pipeline state sharding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an end-to-end smoke test for the LTX2 model in MaxDiffusion and updates the environment setup script to handle virtual environments more robustly.
Key Changes
1. LTX2 Smoke Test
src/maxdiffusion/tests/ltx2_smoke_test.pyto provide a basic verification that LTX2 generation runs successfully on the configured hardware. This follows similar patterns used for the Wan model tests.2. Environment Setup (
setup.sh)PIP_INDEX_URLandUV_INDEX_URLtohttps://pypi.org/simpleto ensure standard resolution from PyPI.UV_SYSTEM_PYTHON: Instead of forcinguvto use the system Python by default, added a check to detect if the script is running within a virtual environment.UV_SYSTEM_PYTHON=1.UV_SYSTEM_PYTHON=1to maintain compatibility with typical bare-metal TPU VM workflows where we want to use the system package space.Verification Results
setup.shworks as expected when run inside and outside a venv.