Delegate to reduce actual implementations; improve doc'n comments

J Burnett · J Burnett · commit 7b271f490366 · 2017-11-02T17:37:28.000-04:00
diff --git a/AMT.LinqExtensions/LinqExtensions.cs b/AMT.LinqExtensions/LinqExtensions.cs
@@ -21,9 +21,14 @@ public static class LinqRandomizer
 		///<exception cref="System.ArgumentOutOfRangeException">Thrown when the list is empty</exception>
 		public static T Random<T> (this ICollection<T> elements)
 		{
-			return elements.ElementAt(_randomizer.Next(0, elements.Count - 1));
+			// Delegate to overload taking IEnumerable 
+			return Random<T>(elements as IEnumerable<T>);
 		}
 
+		///<summary>Returns a random element using an enumerable</summary>
+		///<typeparam name="T">The element type of the enumerable</typeparam>
+		///<param cref="elements">An IEnumerable of the specified type <seealso cref="T" /></param>
+		///<exception cref="System.ArgumentOutOfRangeException">Thrown when the list is empty</exception>
 		public static T Random<T> (this IEnumerable<T> elements)
 		{
 			return elements.ElementAt(_randomizer.Next(0, elements.Count() - 1));

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,14 @@ public static class LinqRandomizer`
`21`	`21`	`///<exception cref="System.ArgumentOutOfRangeException">Thrown when the list is empty</exception>`
`22`	`22`	`public static T Random<T> (this ICollection<T> elements)`
`23`	`23`	`{`
`24`		`- return elements.ElementAt(_randomizer.Next(0, elements.Count - 1));`
	`24`	`+ // Delegate to overload taking IEnumerable`
	`25`	`+ return Random<T>(elements as IEnumerable<T>);`
`25`	`26`	`}`
`26`	`27`
	`28`	`+ ///<summary>Returns a random element using an enumerable</summary>`
	`29`	`+ ///<typeparam name="T">The element type of the enumerable</typeparam>`
	`30`	`+ ///<param cref="elements">An IEnumerable of the specified type <seealso cref="T" /></param>`
	`31`	`+ ///<exception cref="System.ArgumentOutOfRangeException">Thrown when the list is empty</exception>`
`27`	`32`	`public static T Random<T> (this IEnumerable<T> elements)`
`28`	`33`	`{`
`29`	`34`	`return elements.ElementAt(_randomizer.Next(0, elements.Count() - 1));`