chore: code cleanup#2200
Open
Ayaz-Microsoft wants to merge 2 commits intoAzure-Samples:devfrom
Open
Conversation
…, connection, and workspace. These modules are no longer needed and have been deleted to streamline the infrastructure codebase. -Disable prompt_flow from UI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reverts the prompt_flow UI filter from commit b15c665. Bicep cleanup (orphaned ML modules + unused DNS zone) is preserved. No prompt_flow related code is changed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ayaz-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the infrastructure layer by removing unused Azure Machine Learning (AML) workspace-related Bicep modules and updating the root infra template/compiled ARM output to reflect the removal (including dropping the AML private DNS zone entry).
Changes:
- Deleted unused AML workspace / connection / compute Bicep modules under
infra/modules/machine-learning-services/workspace/. - Removed
privatelink.api.azureml.msfrom theprivateDnsZoneslist and dropped the correspondingdnsZoneIndex.machinelearningentry. - Regenerated
infra/main.jsonto reflect the above template updates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/modules/machine-learning-services/workspace/ml_workspace.bicep | Removed unused AML workspace module. |
| infra/modules/machine-learning-services/workspace/connection/connection.bicep | Removed unused AML workspace connection module. |
| infra/modules/machine-learning-services/workspace/compute/compute.bicep | Removed unused AML workspace compute module. |
| infra/main.bicep | Removed AML private DNS zone entry and updated DNS zone index map accordingly. |
| infra/main.json | Updated generated ARM template to match main.bicep changes (including generator metadata changes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
10
| "_generator": { | ||
| "name": "bicep", | ||
| "version": "0.42.1.51946", | ||
| "templateHash": "16421140691716802279" | ||
| "version": "0.41.2.15936", | ||
| "templateHash": "3012272495014352042" | ||
| } |
Comment on lines
621
to
625
| 'privatelink.file.${environment().suffixes.storage}' | ||
| 'privatelink.search.windows.net' | ||
| 'privatelink.cognitiveservices.azure.com' | ||
| 'privatelink.openai.azure.com' | ||
| 'privatelink.vaultcore.azure.net' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
-Disable prompt_flow from UI
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information