fix: Speech service API issue fixed#2202
Open
AjitPadhi-Microsoft wants to merge 1 commit intoAzure-Samples:devfrom
Open
fix: Speech service API issue fixed#2202AjitPadhi-Microsoft wants to merge 1 commit intoAzure-Samples:devfrom
AjitPadhi-Microsoft wants to merge 1 commit intoAzure-Samples:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
speech_configis updated to use a managed identity and AAD token whenAZURE_AUTH_TYPEis set to "rbac". Corresponding tests are refactored to cover this new authentication flow.Authentication logic updates:
code/create_app.py: Thespeech_configfunction now supports both key-based and RBAC (Azure Active Directory) authentication. WhenAZURE_AUTH_TYPEis "rbac", it retrieves an AAD token using a managed identity and uses it to request a speech token, instead of a subscription key.Test updates:
code/tests/test_create_app.py: The test setup (env_helper_mock) and thetest_returns_speech_token_using_rbactest are updated to mock the new RBAC authentication flow, including checking that the correct credential and token retrieval calls are made. [1] [2] [3]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information