Fix sequential elements image blending issue#454
Fix sequential elements image blending issue#454KumarAr0631F wants to merge 1 commit intoCircuitVerse:masterfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (10)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
senutpal
left a comment
There was a problem hiding this comment.
I see you replaced the transparent background images with white background versions. While this does fix the visibility issue, I think a CSS-based approach might work better here. The new images are 140-230% larger in file size, and we'd need to manually edit any future images too.
As the issue author suggested, we could use CSS instead. We can even apply it only in dark mode:
[data-theme='dark'] img[src*="chapter4/4."] {
background-color: #ffffff;
padding: 8px;
display: inline-block;
border-radius: 4px;
}Note: I’m commenting as a community contributor, not a maintainer.
CC @Nihal4777
@KumarAr0631F What do you think about this? |
…e where transparent images with black elementsblend into the dark background. CSS-only fix that applies globallyto all documentation pages.Fixes CircuitVerse#454
Fixes #416
Summary
This PR improves the visual clarity of images in Chapter 4 – Sequential Elements of the CircuitVerse documentation by adding a proper background behind the images. The update ensures better contrast and consistency with the overall documentation theme.
Changes Made
Why this change?
Previously, some images blended into the page background, making them harder to distinguish. Adding a background enhances user experience, especially for learners viewing the documentation on different screen sizes and themes.
Screenshots
Before:

After:

Checklist