fix: increase all gate embed sizes for better readability#510
fix: increase all gate embed sizes for better readability#510arnav25102004 wants to merge 1 commit intoCircuitVerse:masterfrom
Conversation
WalkthroughThe documentation file 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/chapter4/4gates.md (1)
28-38:⚠️ Potential issue | 🟡 MinorAvoid duplicate
id="projectPreview"across multiple iframes.IDs must be unique per page; duplicates can break anchors, scripting, and accessibility tooling. Prefer unique IDs or drop the
idand use a shared class instead.✅ Suggested fix (unique ids or class)
- id="projectPreview" + class="project-preview"- id="projectPreview" + id="projectPreview-and-gate"Also applies to: 43-54, 71-82, 99-110, 125-136, 153-162, 179-190, 207-218, 235-246
🧹 Nitpick comments (1)
docs/chapter4/4gates.md (1)
28-31: Consider responsive sizing to avoid mobile overflow.Fixed 600×400px can overflow small screens. A responsive width with a max-width and aspect ratio keeps readability without breaking layout.
💡 Suggested approach (CSS class)
- width="600px" - height="400px" + class="project-preview".project-preview { width: 100%; max-width: 600px; aspect-ratio: 3 / 2; height: auto; }Also applies to: 43-46, 71-74, 99-102, 125-128, 153-156, 179-182, 207-210, 235-238
Fixes #509
Changes done:
docs/chapter4/4gates.mdAll embedded circuit iframes on the Gates page were set to 300x200px which made the gates and connections difficult to see clearly. Increased all 9 iframes to 600x400px so the circuits are clearly visible and readable.
The issue mentioned only the AND gate, but every single embed on this page had the same problem so fixed them all together.
Screenshots:
BEFORE -

AFTER -

Preview Link(s):
✅️ By submitting this PR, I have verified the following
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.