fix: replace GestureDetector with InkWell in ProjectCard for ripple f…#560
fix: replace GestureDetector with InkWell in ProjectCard for ripple f…#560RAJEEVTIWARI8052 wants to merge 2 commits intoCircuitVerse:masterfrom
Conversation
✅ Deploy Preview for cv-mobile-app-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe project card's interaction was changed from a top-level 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 37212bfc-b4e0-4dc9-a712-645baf8646a1
📒 Files selected for processing (1)
lib/ui/views/projects/components/project_card.dart
|
"Hey @JatsuAkaYashvant , I have pushed the fixes for this issue. Could you please take a look when you have a free moment? Thanks!" |
Fixes #559
Describe the changes you have made in this PR:
GestureDetectorwithInkWellinside the Card widget in lib/ui/views/projects/components/project_card.dart.clipBehavior: Clip.antiAliasto the Card to ensure the Material ripple effect stays neatly bounded within the card's rounded corners.Why these changes were necessary:
The ProjectCard component was using
GestureDetectorto handle taps, which captures touch events but provides no visual feedback to the user. This makes the card feel unresponsive and "dead" when tapped. By switching toInkWell(a proper Material Design widget), users now see a smooth ripple animation every time they tap a project card, making the app feel significantly more interactive and polished.Summary by CodeRabbit