Skip to content

fix: replace GestureDetector with InkWell in ProjectCard for ripple f…#560

Open
RAJEEVTIWARI8052 wants to merge 2 commits intoCircuitVerse:masterfrom
RAJEEVTIWARI8052:fix/inkwell-ripple-project-card
Open

fix: replace GestureDetector with InkWell in ProjectCard for ripple f…#560
RAJEEVTIWARI8052 wants to merge 2 commits intoCircuitVerse:masterfrom
RAJEEVTIWARI8052:fix/inkwell-ripple-project-card

Conversation

@RAJEEVTIWARI8052
Copy link
Copy Markdown

@RAJEEVTIWARI8052 RAJEEVTIWARI8052 commented Mar 24, 2026

Fixes #559

Describe the changes you have made in this PR:

  • Replaced GestureDetector with InkWell inside the Card widget in lib/ui/views/projects/components/project_card.dart.
  • Added clipBehavior: Clip.antiAlias to the Card to ensure the Material ripple effect stays neatly bounded within the card's rounded corners.

Why these changes were necessary:

The ProjectCard component was using GestureDetector to handle taps, which captures touch events but provides no visual feedback to the user. This makes the card feel unresponsive and "dead" when tapped. By switching to InkWell (a proper Material Design widget), users now see a smooth ripple animation every time they tap a project card, making the app feel significantly more interactive and polished.

Summary by CodeRabbit

  • Style
    • Project cards now provide material-style ink ripple feedback with improved tap responsiveness. Visual interaction boundaries are better aligned with card edges so ripples and highlights are clipped neatly, while existing spacing and layout are preserved.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 24, 2026

Deploy Preview for cv-mobile-app-web ready!

Name Link
🔨 Latest commit ce4499f
🔍 Latest deploy log https://app.netlify.com/projects/cv-mobile-app-web/deploys/69c2f2c4173e4b000715c502
😎 Deploy Preview https://deploy-preview-560--cv-mobile-app-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a94045ed-333a-4cec-ac44-6112565c82e7

📥 Commits

Reviewing files that changed from the base of the PR and between a335dda and ce4499f.

📒 Files selected for processing (1)
  • lib/ui/views/projects/components/project_card.dart
🚧 Files skipped from review as they are similar to previous changes (1)
  • lib/ui/views/projects/components/project_card.dart

Walkthrough

The project card's interaction was changed from a top-level GestureDetector to an InkWell placed inside the Card. The onTap handler was moved to the InkWell. The Card now sets clipBehavior: Clip.antiAlias to constrain ink effects; the surrounding PaddingCardColumn structure remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main change: replacing GestureDetector with InkWell in ProjectCard to enable ripple feedback.
Linked Issues check ✅ Passed The PR directly addresses issue #559 by replacing GestureDetector with InkWell in project_card.dart and adding clipBehavior: Clip.antiAlias as specified.
Out of Scope Changes check ✅ Passed All changes are scoped to project_card.dart and directly address the linked issue #559 requirement; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37212bfc-b4e0-4dc9-a712-645baf8646a1

📥 Commits

Reviewing files that changed from the base of the PR and between f621531 and a335dda.

📒 Files selected for processing (1)
  • lib/ui/views/projects/components/project_card.dart

Comment thread lib/ui/views/projects/components/project_card.dart Outdated
@RAJEEVTIWARI8052
Copy link
Copy Markdown
Author

"Hey @JatsuAkaYashvant , I have pushed the fixes for this issue. Could you please take a look when you have a free moment? Thanks!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement / Frontend]: Replace GestureDetector with InkWell on interactive components for visual touch feedback

1 participant