feat: migrate to Android SDK 36 and support Predictive Back Gesture#569
feat: migrate to Android SDK 36 and support Predictive Back Gesture#569DELTA-45-G wants to merge 1 commit intoCircuitVerse:masterfrom
Conversation
✅ Deploy Preview for cv-mobile-app-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis pull request updates the Android build configuration and project dependencies. Changes include: updating Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
android/app/build.gradle (1)
122-126: Consider updating outdated test dependencies.The test dependencies are quite dated:
junit:junit:4.12(released 2014, current: 4.13.2)androidx.test:runner:1.1.1(current: 1.6.x)androidx.test.espresso:espresso-core:3.1.1(current: 3.6.x)While not blocking, updating these would improve test reliability and access to bug fixes.
♻️ Suggested dependency updates
dependencies { - testImplementation 'junit:junit:4.12' - androidTestImplementation 'androidx.test:runner:1.1.1' - androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1' + testImplementation 'junit:junit:4.13.2' + androidTestImplementation 'androidx.test:runner:1.6.2' + androidTestImplementation 'androidx.test.espresso:espresso-core:3.6.1' }
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 065a682d-8600-444d-bd1e-2e8f90cf5672
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
android/app/build.gradleandroid/gradle/wrapper/gradle-wrapper.propertiesandroid/settings.gradlel10n.yamlwindows/flutter/generated_plugin_registrant.ccwindows/flutter/generated_plugins.cmake
Fixes #567
This PR performs a critical environment migration and modernization:
Upgraded compileSdk and targetSdk to 36 to resolve dependency conflicts with androidx.browser.
Updated Gradle wrapper to 8.11.1 and AGP to 8.9.1 for compatibility.
Enabled android:enableOnBackInvokedCallback in the Manifest to support modern Android navigation.
Resolved synthetic-package deprecation warning in l10n.yaml.
Summary by CodeRabbit