Merged
Conversation
Contributor
Author
|
@decause-gov If we don't want this schema to be the one on prod, feel free to close his PR! |
decause-gov
approved these changes
Jul 23, 2025
Contributor
decause-gov
left a comment
decause-gov
left a comment
There was a problem hiding this comment.
LGTM +1 🚢
Nice work Nat 🤝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the maximal schema is being used in prod: https://dsacms.github.io/codejson-generator/
We would like to use the minimal schema instead.
Solution
Updated
schema.jsonundergovdirectory to use the minimal schema. Minimal schema only includes required fields from M16-21, SHARE IT Act, and M25-21. Removed majority ofpubliccode.ymlfields.Result
Minimal schema is being used in prod: https://dsacms.github.io/codejson-generator/
Test Plan
Tested locally