chore(ci): move crashtracker tests into its own test suite#17526
Conversation
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
Codeowners resolved as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a0fa76b9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
080def2 to
7395e26
Compare
7395e26 to
6c89cfa
Compare
DD_XOP6TT Co-authored-by: gyuheon0h <102937919+gyuheon0h@users.noreply.github.com>
6c89cfa to
370f028
Compare
370f028 to
e46fd2e
Compare
Performance SLOsComparing candidate dd/isolate-crashtracker-tests-with-service-names (a031bd8) with baseline main (e5d3d47) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.182µs (SLO: <130.000µs 📉 -20.6%) vs baseline: +3.2% Memory: ✅ 43.921MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ add_inplace_aspectTime: ✅ 99.862µs (SLO: <130.000µs 📉 -23.2%) vs baseline: -0.4% Memory: ✅ 43.843MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 28.169µs (SLO: <40.000µs 📉 -29.6%) vs baseline: -1.0% Memory: ✅ 43.912MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 49.084µs (SLO: <70.000µs 📉 -29.9%) vs baseline: +0.4% Memory: ✅ 43.959MB (SLO: <46.000MB -4.4%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 249.292µs (SLO: <400.000µs 📉 -37.7%) vs baseline: -1.2% Memory: ✅ 43.864MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 641.484µs (SLO: <800.000µs 📉 -19.8%) vs baseline: -0.1% Memory: ✅ 43.861MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 268.007µs (SLO: <400.000µs 📉 -33.0%) vs baseline: +0.4% Memory: ✅ 43.938MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 138.333µs (SLO: <300.000µs 📉 -53.9%) vs baseline: -1.8% Memory: ✅ 43.862MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 218.147µs (SLO: <300.000µs 📉 -27.3%) vs baseline: -0.3% Memory: ✅ 43.904MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 136.646µs (SLO: <200.000µs 📉 -31.7%) vs baseline: +2.1% Memory: ✅ 43.971MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 3.802ms (SLO: <5.000ms 📉 -24.0%) vs baseline: ~same Memory: ✅ 43.921MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 316.564µs (SLO: <420.000µs 📉 -24.6%) vs baseline: +1.2% Memory: ✅ 43.938MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 88.469µs (SLO: <300.000µs 📉 -70.5%) vs baseline: -0.8% Memory: ✅ 43.901MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 250.281µs (SLO: <300.000µs 📉 -16.6%) vs baseline: +2.0% Memory: ✅ 43.927MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 92.580µs (SLO: <500.000µs 📉 -81.5%) vs baseline: +5.0% Memory: ✅ 43.890MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 303.764µs (SLO: <500.000µs 📉 -39.2%) vs baseline: -0.8% Memory: ✅ 43.833MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 86.791µs (SLO: <100.000µs 📉 -13.2%) vs baseline: +0.3% Memory: ✅ 43.789MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 156.123µs (SLO: <210.000µs 📉 -25.7%) vs baseline: +1.5% Memory: ✅ 43.907MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 84.320µs (SLO: <200.000µs 📉 -57.8%) vs baseline: ~same Memory: ✅ 43.909MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 142.411µs (SLO: <200.000µs 📉 -28.8%) vs baseline: -0.5% Memory: ✅ 44.006MB (SLO: <46.000MB -4.3%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 14.556ms (SLO: <19.200ms 📉 -24.2%) vs baseline: +0.2% Memory: ✅ 44.010MB (SLO: <46.000MB -4.3%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 16.383ms (SLO: <21.500ms 📉 -23.8%) vs baseline: ~same Memory: ✅ 43.932MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 370.144µs (SLO: <500.000µs 📉 -26.0%) vs baseline: +0.3% Memory: ✅ 43.931MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 309.544µs (SLO: <500.000µs 📉 -38.1%) vs baseline: +0.1% Memory: ✅ 43.935MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 123.848µs (SLO: <300.000µs 📉 -58.7%) vs baseline: +0.7% Memory: ✅ 43.854MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 40.781µs (SLO: <300.000µs 📉 -86.4%) vs baseline: +0.8% Memory: ✅ 43.820MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ join_aspectTime: ✅ 209.250µs (SLO: <300.000µs 📉 -30.3%) vs baseline: -0.4% Memory: ✅ 43.845MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 141.268µs (SLO: <300.000µs 📉 -52.9%) vs baseline: +0.5% Memory: ✅ 43.933MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 499.619µs (SLO: <700.000µs 📉 -28.6%) vs baseline: ~same Memory: ✅ 43.932MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 259.666µs (SLO: <300.000µs 📉 -13.4%) vs baseline: +1.6% Memory: ✅ 43.819MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ lower_aspectTime: ✅ 296.594µs (SLO: <500.000µs 📉 -40.7%) vs baseline: +0.5% Memory: ✅ 43.987MB (SLO: <46.000MB -4.4%) vs baseline: +5.2% ✅ lower_noaspectTime: ✅ 231.229µs (SLO: <300.000µs 📉 -22.9%) vs baseline: -0.6% Memory: ✅ 43.832MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 0.342ms (SLO: <3.000ms 📉 -88.6%) vs baseline: 📈 +26.8% Memory: ✅ 43.963MB (SLO: <46.000MB -4.4%) vs baseline: +5.1% ✅ lstrip_noaspectTime: ✅ 0.176ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -0.7% Memory: ✅ 43.948MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 14.218ms (SLO: <18.750ms 📉 -24.2%) vs baseline: +0.3% Memory: ✅ 44.008MB (SLO: <46.000MB -4.3%) vs baseline: +4.6% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.687ms (SLO: <19.350ms 📉 -24.1%) vs baseline: -0.3% Memory: ✅ 43.979MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 14.312ms (SLO: <18.900ms 📉 -24.3%) vs baseline: ~same Memory: ✅ 44.034MB (SLO: <46.000MB -4.3%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.549ms (SLO: <19.150ms 📉 -24.0%) vs baseline: -0.1% Memory: ✅ 44.034MB (SLO: <46.000MB -4.3%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.360ms (SLO: <3.000ms 📉 -88.0%) vs baseline: -0.8% Memory: ✅ 43.844MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ replace_aspectTime: ✅ 18.315ms (SLO: <24.000ms 📉 -23.7%) vs baseline: ~same Memory: ✅ 43.978MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 305.352µs (SLO: <400.000µs 📉 -23.7%) vs baseline: +6.9% Memory: ✅ 43.875MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 322.890µs (SLO: <420.000µs 📉 -23.1%) vs baseline: -0.3% Memory: ✅ 43.941MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 46.634µs (SLO: <90.000µs 📉 -48.2%) vs baseline: -0.5% Memory: ✅ 43.895MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 377.812µs (SLO: <500.000µs 📉 -24.4%) vs baseline: -0.4% Memory: ✅ 43.914MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 183.949µs (SLO: <300.000µs 📉 -38.7%) vs baseline: ~same Memory: ✅ 43.927MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 183.249µs (SLO: <300.000µs 📉 -38.9%) vs baseline: -0.2% Memory: ✅ 43.843MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 54.064µs (SLO: <90.000µs 📉 -39.9%) vs baseline: -0.4% Memory: ✅ 43.851MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 3.882ms (SLO: <5.000ms 📉 -22.4%) vs baseline: +0.9% Memory: ✅ 43.861MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 347.531µs (SLO: <500.000µs 📉 -30.5%) vs baseline: +0.9% Memory: ✅ 43.850MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 271.225µs (SLO: <350.000µs 📉 -22.5%) vs baseline: +0.5% Memory: ✅ 43.946MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 176.896µs (SLO: <240.000µs 📉 -26.3%) vs baseline: -0.2% Memory: ✅ 43.819MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 330.268µs (SLO: <500.000µs 📉 -33.9%) vs baseline: ~same Memory: ✅ 43.907MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 267.224µs (SLO: <400.000µs 📉 -33.2%) vs baseline: -0.6% Memory: ✅ 43.874MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 319.944µs (SLO: <500.000µs 📉 -36.0%) vs baseline: -1.8% Memory: ✅ 43.846MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 258.174µs (SLO: <400.000µs 📉 -35.5%) vs baseline: -0.3% Memory: ✅ 43.793MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 491.650µs (SLO: <700.000µs 📉 -29.8%) vs baseline: -0.3% Memory: ✅ 43.922MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 438.700µs (SLO: <500.000µs 📉 -12.3%) vs baseline: +2.5% Memory: ✅ 43.778MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ upper_aspectTime: ✅ 297.553µs (SLO: <500.000µs 📉 -40.5%) vs baseline: +0.5% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 233.711µs (SLO: <400.000µs 📉 -41.6%) vs baseline: +0.9% Memory: ✅ 43.944MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 530.388µs (SLO: <700.000µs 📉 -24.2%) vs baseline: 📈 +24.2% Memory: ✅ 43.872MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 432.408µs (SLO: <700.000µs 📉 -38.2%) vs baseline: +0.1% Memory: ✅ 43.780MB (SLO: <46.000MB -4.8%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 628.695µs (SLO: <700.000µs 📉 -10.2%) vs baseline: +0.1% Memory: ✅ 43.920MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 635.185µs (SLO: <700.000µs -9.3%) vs baseline: -1.1% Memory: ✅ 43.891MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 349.955µs (SLO: <700.000µs 📉 -50.0%) vs baseline: +0.3% Memory: ✅ 43.939MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 361.853µs (SLO: <700.000µs 📉 -48.3%) vs baseline: +1.2% Memory: ✅ 43.812MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ ospathsplit_aspectTime: ✅ 488.928µs (SLO: <700.000µs 📉 -30.2%) vs baseline: -1.1% Memory: ✅ 43.866MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 504.037µs (SLO: <700.000µs 📉 -28.0%) vs baseline: ~same Memory: ✅ 43.830MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 372.842µs (SLO: <700.000µs 📉 -46.7%) vs baseline: +0.2% Memory: ✅ 43.856MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 72.999µs (SLO: <700.000µs 📉 -89.6%) vs baseline: -0.7% Memory: ✅ 43.839MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 464.507µs (SLO: <700.000µs 📉 -33.6%) vs baseline: -0.5% Memory: ✅ 43.800MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 470.138µs (SLO: <700.000µs 📉 -32.8%) vs baseline: -0.3% Memory: ✅ 43.732MB (SLO: <46.000MB -4.9%) vs baseline: +4.4% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 19.621ms (SLO: <22.300ms 📉 -12.0%) vs baseline: +0.2% Memory: ✅ 71.273MB (SLO: <73.500MB -3.0%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.364ms (SLO: <1.450ms -6.0%) vs baseline: -0.3% Memory: ✅ 69.552MB (SLO: <71.500MB -2.7%) vs baseline: +4.9% ✅ iastTime: ✅ 19.719ms (SLO: <22.250ms 📉 -11.4%) vs baseline: +0.1% Memory: ✅ 71.234MB (SLO: <75.000MB -5.0%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.226ms (SLO: <16.550ms -8.0%) vs baseline: +0.2% Memory: ✅ 60.298MB (SLO: <61.000MB 🟡 -1.2%) vs baseline: +5.3% ✅ resource-renamingTime: ✅ 19.485ms (SLO: <21.750ms 📉 -10.4%) vs baseline: -0.3% Memory: ✅ 71.267MB (SLO: <73.500MB -3.0%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 20.203ms (SLO: <28.200ms 📉 -28.4%) vs baseline: +1.6% Memory: ✅ 71.462MB (SLO: <75.000MB -4.7%) vs baseline: +4.7% ✅ tracerTime: ✅ 19.602ms (SLO: <21.750ms -9.9%) vs baseline: ~same Memory: ✅ 71.238MB (SLO: <75.000MB -5.0%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 21.003ms (SLO: <23.500ms 📉 -10.6%) vs baseline: -0.1% Memory: ✅ 73.195MB (SLO: <75.000MB -2.4%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.718ms (SLO: <21.500ms -8.3%) vs baseline: +0.3% Memory: ✅ 71.212MB (SLO: <75.000MB -5.1%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 17.816ms (SLO: <18.500ms -3.7%) vs baseline: -0.7% Memory: ✅ 71.119MB (SLO: <75.000MB -5.2%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.847ms (SLO: <19.650ms -4.1%) vs baseline: +0.1% Memory: ✅ 71.179MB (SLO: <75.000MB -5.1%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 20.751ms (SLO: <21.100ms 🟡 -1.7%) vs baseline: +0.5% Memory: ✅ 71.284MB (SLO: <75.000MB -5.0%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 19.361ms (SLO: <21.500ms -9.9%) vs baseline: ~same Memory: ✅ 71.281MB (SLO: <75.000MB -5.0%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.826ms (SLO: <22.000ms -5.3%) vs baseline: +1.2% Memory: ✅ 71.234MB (SLO: <73.500MB -3.1%) vs baseline: +5.0% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.749ms (SLO: <47.150ms 📉 -13.6%) vs baseline: +0.4% Memory: ✅ 41.159MB (SLO: <47.000MB 📉 -12.4%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 235.444ms (SLO: <344.800ms 📉 -31.7%) vs baseline: -0.5% Memory: ✅ 45.677MB (SLO: <47.500MB -3.8%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 264.788ms (SLO: <330.000ms 📉 -19.8%) vs baseline: -0.2% Memory: ✅ 45.812MB (SLO: <47.500MB -3.6%) vs baseline: +4.9% ✅ get-contextTime: ✅ 83.767ms (SLO: <92.350ms -9.3%) vs baseline: -0.2% Memory: ✅ 41.602MB (SLO: <46.500MB 📉 -10.5%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 39.044ms (SLO: <44.500ms 📉 -12.3%) vs baseline: +0.5% Memory: ✅ 41.139MB (SLO: <47.500MB 📉 -13.4%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 61.042ms (SLO: <67.650ms -9.8%) vs baseline: -0.5% Memory: ✅ 41.744MB (SLO: <47.000MB 📉 -11.2%) vs baseline: +4.8% ✅ set-statusTime: ✅ 44.818ms (SLO: <50.400ms 📉 -11.1%) vs baseline: +0.2% Memory: ✅ 41.048MB (SLO: <47.000MB 📉 -12.7%) vs baseline: +4.4% ✅ startTime: ✅ 40.104ms (SLO: <44.500ms -9.9%) vs baseline: +4.0% Memory: ✅ 41.099MB (SLO: <47.000MB 📉 -12.6%) vs baseline: +4.7% ✅ start-finishTime: ✅ 89.958ms (SLO: <92.000ms -2.2%) vs baseline: -0.2% Memory: ✅ 38.751MB (SLO: <46.500MB 📉 -16.7%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 91.609ms (SLO: <93.000ms 🟡 -1.5%) vs baseline: ~same Memory: ✅ 38.791MB (SLO: <46.500MB 📉 -16.6%) vs baseline: +4.6% ✅ update-nameTime: ✅ 40.030ms (SLO: <45.150ms 📉 -11.3%) vs baseline: -0.2% Memory: ✅ 41.276MB (SLO: <47.000MB 📉 -12.2%) vs baseline: +4.6% 🟡 packagesupdateimporteddependencies - 24/24 (1 unstable)✅ import_manyTime: ✅ 157.013µs (SLO: <170.000µs -7.6%) vs baseline: +0.4% Memory: ✅ 41.131MB (SLO: <46.000MB 📉 -10.6%) vs baseline: +4.6% ✅ import_many_cachedTime: ✅ 121.797µs (SLO: <130.000µs -6.3%) vs baseline: -0.1% Memory: ✅ 41.269MB (SLO: <46.000MB 📉 -10.3%) vs baseline: +5.1% ✅ import_many_stdlibTime: ✅ 1.256ms (SLO: <1.750ms 📉 -28.2%) vs baseline: +1.0% Memory: ✅ 41.197MB (SLO: <46.000MB 📉 -10.4%) vs baseline: +5.1%
|
brettlangdon
left a comment
There was a problem hiding this comment.
some nits, but overall lgtm thanks!
brettlangdon
left a comment
There was a problem hiding this comment.
last thought, CODEOWNERS? since these will default to core, right?
2101f75 to
2437658
Compare
…nstead of parallelism
2437658 to
a031bd8
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|

Description
Move crashtracking tests in its own test suite.
Increase test timeout and used service based log query to minimize potential race conditions on which logs are retrieved (although, I think I correctly made the crashtracker test suite to run sequentially, so this shouldn't be an issue?)
Based on how flaky these tests were with the most random timeouts and random failures, I suspect maybe resource contention and running all internal tests in parallel had to play a part in these issues
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1596110887
Omg! I haven't seen all crashtracker test pass in one go without needing quarantine to help it pass ever!
Ticket: PROF-14283