convert integer type setting to integer#217
Open
linsong wants to merge 4 commits intoFreeboard:masterfrom
Open
convert integer type setting to integer#217linsong wants to merge 4 commits intoFreeboard:masterfrom
linsong wants to merge 4 commits intoFreeboard:masterfrom
Conversation
added 4 commits
April 18, 2017 08:32
The data-sizex will be set directly by value of paneModel.col_width(),
and by default paneModel.col_width() is a number string, not number.
This will cause issues when gridster plugin trys to caclulate layout,
because for example 'string number'+'real number' will return a string
with two number string concated, not a number("1" + 3 = "13"), I think
this may cause some weird layout issue.
This reverts commit 0c39b12.
AFAIU, there is only one integer type setting, that is Pane's 'Columns'. The columns value wil be used to calculate layout later by gridster plugin. If we don't convert the setting to integer, then it may cause undesired result later, considering plus a string number to a real number like this: '1' + 3 = '13', and then cause some layout issue.
joed74
added a commit
to joed74/freeboard-mqtt
that referenced
this pull request
Aug 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIU, there is only one integer type setting, that is Pane's 'Columns'. The columns value wil be used to calculate layout later by gridster plugin. If we don't convert the setting to integer, then it may cause undesired result later, considering plus a string number to a real number like this: '1' + 3 = '13', and then cause some layout issue.