Fix incorrect use of expression reification#403
Open
NotHyper-474 wants to merge 1 commit intoFunkinCrew:experimentalfrom
Open
Fix incorrect use of expression reification#403NotHyper-474 wants to merge 1 commit intoFunkinCrew:experimentalfrom
NotHyper-474 wants to merge 1 commit intoFunkinCrew:experimentalfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
This PR fixes an improper use of expression reification in a macro, we only use these after a
macrokeyword AND if we're trying to get an Expr, but we all it wants is to format a string so it's not actually needed.