Merged
Conversation
* feat: default cfg * feat: add alert_ntfy call * feat: init alert_ntfy * fix: ntfy alert should be off by default * fix: add alert_ntfy to core modules * feat: add ntfy to all default configs --------- Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
* Updated the IFTTT alert output to only display when the alert is set to "on". * This change ensures that unnecessary output is avoided when the alert is not active.
* add compatabilty message * failure * fix(serverlist): Update Vintage Story OS version to ubuntu-24.04 * Corrected the operating system version for `Vintage Story` from `ubuntu-22.04` to `ubuntu-24.04`. * Ensures compatibility with the latest server requirements. * fix(sven): Update dependencies * fix(check_deps): Update support for Ubuntu and Debian versions * Adjusted version checks for supported distributions. * Added specific error messages for unsupported game titles based on OS version.
Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
…he new one (#4854) * feat: refactor update comparison output for consistency and clarity - Replaced direct echo statements with fn_print functions for uniformity in output formatting across multiple update scripts. - Ensured lockfile creation uses the correct syntax for variable expansion. - Moved lock file to the same location to ensure monitor doesnt reboot at the wrong time - Updated remote build information display to enhance readability and maintain consistency in logging. - Removed unnecessary echo commands to streamline the output process. * Refactor remote build version handling across multiple modules - Updated variable names from 'remotebuildversion' to 'remotebuild' for consistency. - Adjusted logic to check for remote build availability using the new variable name. - Modified output messages to reflect the change in variable naming. - Ensured all modules (update_mc.sh, update_mcb.sh, update_mta.sh, update_pmc.sh, update_ts3.sh, update_ut99.sh, update_vints.sh, update_xnt.sh) are aligned with the new naming convention for better readability and maintainability. * fix(alert): resolve issue with servername not always being listed in title * Moved `info_distro.sh`, `info_game.sh`, and `info_messages.sh` calls to the top of the `fn_alert_log` function for better clarity. * Updated `alerticon` assignment to maintain consistency in alert information handling. * fix(alert_discord): remove "More info" field from Discord alert JSON * Eliminated the "More info" field to streamline the alert message. * This change enhances the clarity of the alert by focusing on essential information. * fix(alert): improve update alert messaging for clarity * Updated alert messages in `fn_alert_update` and `fn_alert_update_failed` for better readability. * Changed alert action from `update-request` to `update-restart-request` in `fn_monitor_check_update_source`. * remove inline * fix(alert): Correct grammar in update alert message * Changed "an LinuxGSM update" to "a LinuxGSM update" for grammatical accuracy. * typo * fix(alert_discord): Add inline property to "Is my Game Server Online?" field * Ensures proper formatting of the Discord alert message. * Improves the display of the server status information. * fix(pd): increase timeout for termbin.com connection * fix(alert_discord): reorder fields in Discord alert JSON * Changed the order of fields in the Discord alert JSON structure. * Updated the "More info" and "Is my Game Server Online?" fields for better clarity. * revert back to factorio.com Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Standardizes alert messages across platforms Ensures consistency in alert messages across Discord, NTFY, Pushover, Rocketchat, Slack, and Telegram. Updates Discord alerts to include server hostname and time, removes redundant formatting. Standardizes plain-text alert formatting for NTFY. Refactors Pushover messages to use consistent HTML formatting. Streamlines Rocketchat and Slack messages by removing duplicate server info and adding optional link support. * Removes Hostname from alert messages Removes the Hostname field from various alert messages (Discord, Gotify, IFTTT, ntfy, Pushbullet, Pushover, Rocketchat, Slack, Telegram). The hostname was deemed redundant or unnecessary in the context of these alerts. Relates to #4696 * Configures shellcheckrc filename Configures the Super-Linter action to use `.shellcheckrc` as the BASH_FILE_NAME. This ensures that shellcheck uses the correct configuration file for bash script linting. Fixes #4696 * Disables shellcheck errors and removes variable Disables specific shellcheck errors to allow certain coding patterns and removes an unused variable from the super-linter workflow. This improves the linter's signal-to-noise ratio and reduces unnecessary checks. Relates to #4696 * Fixes and improves server list validation scripts Addresses issues in the server list validation scripts: - Fixes potential issues with parsing curl custom arguments in telegram alerts. - Corrects the shortname array generation. - Implements more robust checks for validating game icons. - Ensures the consistency of server counts across different CSV files. * Fixes glibc check and mod selection logic Corrects glibc version comparison to properly handle version strings. Improves mod installation and removal by validating user input against available options, providing a more robust selection process. This prevents errors caused by invalid mod names and enhances the user experience. Updates arithmetic expression syntax for better compatibility. * Fixes cache control for dev-debug mode Updates the handling of cache control headers in dev-debug mode. The `nocache` variable is changed to an array to correctly pass multiple headers to `curl`. This resolves issues with cached versions of files being used when dev-debug is enabled, ensuring that the latest versions are always fetched. Fixes #4696 * Allows spaces in steamcmdcommand variable Parses steamcmdcommand as an array to allow spaces in the variable. This prevents issues when the user wants to pass arguments with spaces to the steamcmd executable. * Addresses various script improvements Addresses multiple improvements across various scripts: - Fixes Valheim unstripped_corlib override by commenting out the lines in the config files. - Improves process identification for source and goldsrc engines using `pgrep`. - Enhances backup file identification using `find` with `-maxdepth 1` and `-type f`. - Fixes glibc version comparison logic in multiple files. - Improves UT2K4 key installation script by using printf for writing the key to the file. - Corrects the mod info extraction logic to correctly identify mod entries. - Improves amxmodx file installation/removal logic to prevent duplicate entries. - Fixes server info retrieval to handle spaces in the server list. Relates to #4696 * Fixes mono repo install exit code check Corrects the mono repo install exit code check to use the dedicated monorepoexitcode variable, ensuring accurate error detection. Updates the exit trap to preserve the original exit status, preventing potential loss of information when handling script termination. * Refactors and reorders core modules Improves module loading by reordering and refactoring the core modules. This change addresses inconsistencies and improves the overall structure of how core modules are handled within the system. Some fix scripts were renamed to match the module name. * Makes scripts executable Changes file permissions to make shell scripts executable. This ensures that the scripts can be run directly. Addresses a pre-existing issue. Related to #4696 * Adds explicit permissions to workflows Specifies explicit permissions for GitHub Actions workflows to enhance security and control access to resources. This ensures that each workflow only has the necessary permissions, following the principle of least privilege. * Fixes output redirection and URL parsing Corrects output redirection in GitHub Actions workflows by enclosing the $GITHUB_OUTPUT variable in quotes, preventing potential issues with variable expansion. Ensures proper URL parsing in workflows by enclosing the URL within quotes, addressing potential parsing errors. Fixes #4696 * Applies code formatting for consistency Applies Prettier formatting to the codebase for improved readability and consistency. Addresses minor code style inconsistencies across several files. * Fixes minor formatting and logic issues Addresses various minor issues including: - Standardizes indentation in `.editorconfig` for different file types. - Simplifies Prettier configuration. - Updates image links in `README.md`. - Ensures newline character at end of `.csv` files. - Corrects a conditional statement in `command_fastdl.sh`. - Corrects a conditional statement in `info_messages.sh`. - Updates server query protocols in `query_gsquery.py`. * Configures and disables linters Adds YAML linting configuration and disables unnecessary linters to streamline the CI/CD process and reduce noise from irrelevant checks. * Improves documentation and linting Updates documentation links to be enclosed in angle brackets, preventing markdown rendering issues. Configures markdownlint to align with repository standards and avoid common false positives. The updated links in the documentation ensure they are correctly interpreted by markdown parsers, improving user experience. The markdownlint configuration fine-tunes linting rules to better match the project's existing style and conventions, reducing noise from irrelevant warnings. * Fixes typos and improves code consistency Addresses various typos and inconsistencies across multiple files, enhancing code readability and maintainability. Adds codespell and flake8 configurations for linting. Relates to #4696 * Excludes workflow files from Prettier formatting Prevents Prettier from formatting workflow files due to GitHub token restrictions, as the token used by the Prettier auto-commit action lacks permissions to update files within the `.github/workflows/` directory. * chore(prettier): format code * Updates Super-Linter configuration Improves Super-Linter's reliability by switching to linting the entire codebase instead of relying on git history. This change also addresses potential transient fetch failures from GitHub. Additionally, this commit expands the ignored paths in codespell and disables some linters to improve performance and reduce false positives. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: dgibbs64 <dgibbs64@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
Co-authored-by: Anton Siuvaev <anton.siuvaev@xgroup.cy>
Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
1.0 Changed binary paths, so these needs to be updated manually right now. Hopefully someone can merge this. Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
* feat(etl): add downloader and update support for ET: Legacy
Refactors ET: Legacy to use a dedicated update module instead of hardcoded installation files. The new update_etl.sh module leverages the GitHub API to check for, download, and apply the latest builds from GameServerManagers/etlserver-build.
* feat(etl): add update_etl module to core modules
Registers the update_etl.sh module within the core modules to enable the fetching and execution of ET: Legacy updates.
* feat(etl): add update commands to core_getopt
Ensures that the update and check-update commands are available for ET: Legacy by including the etl shortname in the getopt command registration logic.
* feat(etl): improve local build detection
Updates the game log directory to the "legacy" folder and enhances local build detection by parsing etconsole.log for version information, falling back to build.txt if necessary.
* feat(etl): update glibc requirement and log path detection
Updates the minimum glibc requirement to 2.17 and switches the local build detection to use the gamelogdir variable instead of a hardcoded path.
* feat(etl): improve MD5 hash extraction
Updates the MD5 hash parsing to use a specific regex for 32-character hexadecimal strings, providing a more robust extraction from the release body than relying on the last field of the line.
* feat(xnt): add SHA512 hash extraction for remote builds
Updates the Xonotic update module to fetch the SHA512 hash from the remote download server, allowing for build verification and identification.
* fix(xnt): derive sha512 URL from remotebuildfilename not remotebuildtag
Tag format is xonotic-v0.8.6 but the sha512 file is named xonotic-0.8.6.sha512
(without the v). Using remotebuildtag directly produced a 404. Deriving from
remotebuildfilename (which already has the v stripped by tr -d v) gives the
correct URL.
* fix(core_dl): fix zip extraction with extractsrc across devices and non-empty dirs
Using mv to move extracted directories fails in two cases:
- Cross-device moves (e.g. tmp and serverfiles on different Docker volumes)
- Target directory already exists and is non-empty (update scenario)
Replace find+mv with cp -a which handles both cases by copying recursively
and merging into the destination. Also replace the hardcoded 'Xonotic'
temp_extractdir with ${extractsrc} to be generic.
* fix(core_dl): remove duplicate ellipsis in hash verification message
#4897) * fix(install_config): replace cp -nv with explicit file existence check Newer coreutils (Ubuntu 24.04+, Debian 13+) emit a portability warning when using cp -n: 'behavior of -n is non-portable and may change in future'. Replace all cp -nv usages with an explicit [ ! -f dest ] guard, which is portable across all distros and preserves the same OK/SKIP/FAIL behaviour. * fix(install_config): use -e and -L checks to handle broken symlinks Using only -f missed broken symlinks (-e returns false for them but -L returns true). Use both checks to match the skip behaviour of cp -n.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Release prep for v26.1.0, including alerting enhancements, SteamCMD/update improvements, distro/dependency updates, and a large batch of config/workflow cleanups.
Changes:
- Add ntfy alert support and wire it into alert dispatch + default configs.
- Improve SteamCMD/download/update logic (baseappid support, safer argument handling, lockfile updates) and add/adjust server entries (e.g., tf2c, etl).
- Refresh distro/dependency CSVs and GitHub Actions/workflow linting/configuration.
Reviewed changes
Copilot reviewed 222 out of 336 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| lgsm/modules/info_messages.sh | Fix typos and correct glibc comparison quoting; guard IFTTT alert output. |
| lgsm/modules/info_game.sh | Comment typo fixes. |
| lgsm/modules/info_distro.sh | Replace PID detection with pgrep and improve backup file discovery. |
| lgsm/modules/fix_vh.sh | Fix module header and safer sed quoting. |
| lgsm/modules/fix_unt.sh | Fix incorrect module header. |
| lgsm/modules/fix_st.sh | Update module header (but see suggestion re: incorrect name). |
| lgsm/modules/fix_sof2.sh | Fix incorrect module header. |
| lgsm/modules/fix_rust.sh | Fix typo in comment. |
| lgsm/modules/fix_onset.sh | Fix typo in comment. |
| lgsm/modules/fix_dst.sh | Fix typo in comment. |
| lgsm/modules/fix_ark.sh | Fix typos in comments. |
| lgsm/modules/core_trap.sh | Preserve original exit status inside trap handler. |
| lgsm/modules/core_steamcmd.sh | Rename remotebuild variable and adjust update logging/lock timing. |
| lgsm/modules/core_modules.sh | Bump modules version, reorder module fetch functions, add new module entries. |
| lgsm/modules/core_messages.sh | Fix typo in comment. |
| lgsm/modules/core_legacy.sh | Fix typo in description. |
| lgsm/modules/core_getopt.sh | Exclude etl from update options similar to jk2. |
| lgsm/modules/core_dl.sh | SteamCMD invocation refactor, add baseappid install step, typo fixes, zip extraction behavior change. |
| lgsm/modules/command_update_linuxgsm.sh | Make curl nocache flags an array (safer quoting). |
| lgsm/modules/command_update.sh | Route etl updates to update_etl.sh. |
| lgsm/modules/command_stop.sh | Fix typos in comments. |
| lgsm/modules/command_skeleton.sh | Comment/doc wording updates (but see suggestion re: grammar). |
| lgsm/modules/command_postdetails.sh | Fix typo; increase netcat timeout. |
| lgsm/modules/command_monitor.sh | Rename alert type for “restart requested to apply update”. |
| lgsm/modules/command_mods_remove.sh | Replace array-regex membership check with explicit loop. |
| lgsm/modules/command_mods_install.sh | Use arithmetic expansion; replace array-regex membership check with explicit loop. |
| lgsm/modules/command_dev_query_raw.sh | Quote embedded variables in /dev/tcp debug output. |
| lgsm/modules/command_dev_detect_glibc.sh | Fix typo. |
| lgsm/modules/command_details.sh | Fix typo. |
| lgsm/modules/command_debug.sh | Correct glibc comparison quoting. |
| lgsm/modules/command_check_update.sh | Route etl updates to update_etl.sh. |
| lgsm/modules/check_system_requirements.sh | Fix typo in warning message. |
| lgsm/modules/check_permissions.sh | Fix typo in comment. |
| lgsm/modules/check_last_update.sh | Formatting tweak. |
| lgsm/modules/check_glibc.sh | Correct glibc comparison quoting. |
| lgsm/modules/check_deps.sh | Fix exit code capture for mono repo install; add distro gating for some titles. |
| lgsm/modules/alert_telegram.sh | Adjust alert message content; make curlcustomstring parsed into args array. |
| lgsm/modules/alert_slack.sh | Restructure Slack JSON payload construction (needs validation; see suggestions if applicable). |
| lgsm/modules/alert_rocketchat.sh | Restructure Rocket.Chat JSON payload construction. |
| lgsm/modules/alert_pushover.sh | Remove Hostname field; improve “Server Time” formatting. |
| lgsm/modules/alert_pushbullet.sh | Remove Hostname field. |
| lgsm/modules/alert_ntfy.sh | Add new ntfy alert module implementation. |
| lgsm/modules/alert_ifttt.sh | Remove Hostname field. |
| lgsm/modules/alert_gotify.sh | Remove Hostname field. |
| lgsm/modules/alert_discord.sh | Reorder/adjust fields (Server IP/Time/More info/query link). |
| lgsm/modules/alert.sh | Improve update alert messaging, add update-failed + update-restart-request, wire ntfy, reorder info loading. |
| lgsm/data/ubuntu-24.04.csv | Update dependencies (mc JRE, sven deps). |
| lgsm/data/ubuntu-23.10.csv | Adjust sven deps. |
| lgsm/data/ubuntu-23.04.csv | Adjust sven deps. |
| lgsm/data/ubuntu-22.04.csv | Adjust sven deps. |
| lgsm/data/ubuntu-20.04.csv | Adjust sven deps. |
| lgsm/data/ubuntu-18.04.csv | Adjust sven deps. |
| lgsm/data/ubuntu-16.04.csv | Adjust sven deps. |
| lgsm/data/serverlist.csv | Move sven/vints to ubuntu-24.04; add tf2c. |
| lgsm/data/debian-9.csv | Adjust sven deps. |
| lgsm/data/debian-13.csv | Add libicu dependency for scpsl on Debian 13. |
| lgsm/data/debian-11.csv | Adjust sven deps. |
| lgsm/data/debian-10.csv | Adjust sven deps. |
| lgsm/config-default/config-lgsm/zpsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/zmrserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/xntserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/wurmserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/wmcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/wfserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/wetserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/vsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/vpmcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/vintsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/vhserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/utserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ut99server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ut3server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ut2k4server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/untserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/twserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tuserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ts3server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tiserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tfserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tfcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tf2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/tf2cserver/_default.cfg | New default config for TF2 Classified; includes baseappid and settings. |
| lgsm/config-default/config-lgsm/terrariaserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/svenserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/stserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/stnserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/squadserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/squad44server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/solserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sof2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/smserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sfserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sfcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sdtdserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/scpslsmserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/scpslserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sbserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sbotsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/sampserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/rwserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/rustserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/rtcwserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/roserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ricochetserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/qwserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/qlserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/q4server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/q3server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/q2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pzserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pwserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pvrserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pvkiiserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pmcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/pc2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/opforserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/onsetserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ohdserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/nsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ns2server/_default.cfg | Add ntfy alert defaults + typo fix in comment. |
| lgsm/config-default/config-lgsm/ns2cserver/_default.cfg | Add ntfy alert defaults + typo fix in comment. |
| lgsm/config-default/config-lgsm/nmrihserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/necserver/_default.cfg | Add ntfy alert defaults + typo fix. |
| lgsm/config-default/config-lgsm/ndserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/mtaserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/momserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/mohaaserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/mhserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/mcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/mcbserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/l4dserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/l4d2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/kfserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/kf2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/jk2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/jc3server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/jc2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/iosserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/inssserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/insserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/hzserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/hwserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/hldmsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/hldmserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/hl2dmserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/hcuserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/gmodserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/fofserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/fctrserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ets2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/etlserver/_default.cfg | Add ntfy alert defaults + adjust glibc and gamelogdir. |
| lgsm/config-default/config-lgsm/emserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ecoserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dysserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dstserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/doiserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dodsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dodserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dodrserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dmcserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dayzserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/dabserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ctserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/cssserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/csserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/csgoserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/csczserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/cs2server/_default.cfg | Add ntfy alert defaults (but currently duplicated; see suggestion). |
| lgsm/config-default/config-lgsm/colserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/codwawserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/coduoserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/codserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/cod4server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/cod2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/cmwserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ckserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ccserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/btserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/btlserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/boserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bmdmserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bfvserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bf1942server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bdserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bbserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/bb2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/avserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/atsserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/armarserver/_default.cfg | Add ntfy alert defaults + fix typo. |
| lgsm/config-default/config-lgsm/arma3server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/arkserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ahlserver/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/ahl2server/_default.cfg | Add ntfy alert defaults. |
| lgsm/config-default/config-lgsm/acserver/_default.cfg | Add ntfy alert defaults. |
| LICENSE.md | Update copyright year. |
| CONTRIBUTING.md | Adjust formatting of Conventional Commits examples. |
| .shellcheckrc | Disable SC2034 in addition to SC2154. |
| .prettierignore | Ignore workflow files for Prettier auto-commit limitations. |
| .github/workflows/update-copyright-years-in-license-file.yml | Add explicit workflow permissions. |
| .github/workflows/update-check.yml | Add permissions tightening; quote wget URL. |
| .github/workflows/trigger-docker-build.yml | Add permissions tightening. |
| .github/workflows/serverlist-validate.yml | Add permissions tightening. |
| .github/workflows/serverlist-validate.sh | Safer globbing/iteration; exit quoting. |
| .github/workflows/serverlist-validate-game-icons.sh | Safer globbing/iteration; more robust counts and quoting. |
| .github/workflows/potential-duplicates.yml | Add explicit workflow permissions. |
| .github/workflows/git-sync.yml | Add permissions tightening. |
| .github/workflows/details-check.yml | Add permissions; quote $GITHUB_OUTPUT and wget URL. |
| .github/workflows/details-check-generate-matrix.sh | Refactor JSON line emission. |
| .github/workflows/add-to-project.yml | Add permissions tightening. |
| .github/workflows/action-update-copyright-years-in-license-file.yml | Bump checkout action version (see suggestion). |
| .github/workflows/action-super-linter.yml | Bump checkout action version; adjust checkout depth; disable additional linters. |
| .github/workflows/action-prettier.yml | Bump checkout action version (see suggestion). |
| .github/pull_request_template.md | URL formatting tweaks. |
| .github/linters/.yaml-lint.yml | Add YAML lint configuration. |
| .github/linters/.shellcheckrc | Add ShellCheck configuration for Super Linter. |
| .github/linters/.markdown-lint.yml | Add markdownlint configuration. |
| .github/linters/.flake8 | Add flake8 config. |
| .github/linters/.codespellrc | Add codespell configuration. |
| .editorconfig | Fix bash glob; add JSON/ACF/Python defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgibbs64
force-pushed
the
release/v26.1.0
branch
2 times, most recently
from
b992277 to
841dc24
Compare
The 'section' block containing 'fields' and 'accessory' was missing its closing '}' before EOF, producing malformed JSON and breaking all Slack alerts silently (jq -c . would fail on the payload). Also add missing ntfy alert settings to tf2cserver _default.cfg for consistency with other server configs.
- core_dl.sh: use array assignment for steamcmdcommand instead of read -r -a to avoid word-splitting on paths - fix_st.sh: correct module header typo (fix_ts.sh -> fix_st.sh) - command_skeleton.sh: fix grammar 'Creates an copy' -> 'Creates a copy' - serverlist-validate-game-icons.sh: anchor grep to start-of-line and require trailing comma to prevent false positives (e.g. 'tf' matching 'tf2' entries) - cs2server/_default.cfg: remove duplicate ntfy alert settings block
The API version lookup was setting remotebuildversion but all subsequent
jq queries used ${remotebuild}, which was never populated. This caused
'Unable to get remote build' on every install/update.
- Set DEFAULT_BRANCH to current branch to fix 'master not found' error - Use fetch-depth: 0 so GITHUB_BEFORE_SHA can be resolved - Set update_etl.sh executable bit (BASH_EXEC) - Fix .codespellrc tab indentation (EDITORCONFIG) - Add .gitleaks.toml allowlist for GA4 Measurement Protocol API secret (GITLEAKS) - Fix .markdown-lint.yml: disable MD030/MD013/MD033/MD041/MD051 to match existing repo style (MARKDOWN)
dgibbs64
force-pushed
the
release/v26.1.0
branch
from
841dc24 to
db4253f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v26.1.0
New Features
tf2cserver) (feat(tf2classified): add Team Fortress 2 Classified server #4898)etlserver) (feat(etl): add ET: Legacy downloader and update module #4896)Fixes
previousbuild -> localbuild) instead of only the new version (fix (alerts): Alerts on update uses the old game server version not the new one #4854)}brace on the fields/accessory section — was producing invalid JSON and silently breaking all Slack alertscp -nvwith explicit file existence check to fix silent failures on some distros (fix(install_config): replace cp -nv with explicit file existence check #4897)libicu76dependency (Fix(scpslserver/deps): Add libicu76 as dependecy for SCP: Secret Laboratory on Debian 13 #4869)extractsrczip extraction using hardcodedXonotictemp path; fix steamcmd command array handlingCompatibility Updates
Code Quality
fix_ts.sh→ fix_st.sh)cs2server/_default.cfg: Removed duplicate ntfy alert blocktf2cserver/_default.cfg: Added missing ntfy alert settingsType of change