Skip to content

fix: correct handling of IGNORED_ROUTES set to empty #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewrobertson merged 1 commit into from
Mar 27, 2025
Merged

fix: correct handling of IGNORED_ROUTES set to empty #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,13 @@ export function getServer(
}
if (options.ignoredRoutes !== null) {
// Ignored routes is a configuration option that allows requests to specific paths to be prevented
// from invoking the user's function.
app.use(options.ignoredRoutes, (req, res) => {
res.status(404).send(null);
});
// from invoking the user's function. An empty string indicates that no routes should be filtered.
if (options.ignoredRoutes.trim() !== '') {
// Any non-empty string is the used a route expression to return 404 for.
app.use(options.ignoredRoutes, (req, res) => {
res.status(404).send(null);
});
}
} else if (options.signatureType === 'http') {
// We configure some default ignored routes, only for HTTP functions.
app.use('/favicon.ico|/robots.txt', (req, res) => {
Expand Down
Loading