test(securitycenter): fix tests

[bhshkh]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Contributing Guidelines from CONTRIBUTING.MD
• Tests pass: go test -v ./.. (see Testing)
• Code formatted: gofmt (see Formatting)
• Vetting pass: go vet (see Formatting)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Code Review

This pull request introduces retry logic for custom module tests and setup in both Event Threat Detection and Security Health Analytics to improve test stability. Feedback recommends using the more idiomatic structpb.NewStruct for configuration mapping instead of manual construction and ensuring that temporary test modules are registered for cleanup immediately after creation to avoid resource leaks during test failures.

[gemini-code-assist]

The manual construction of structpb.Struct is quite verbose and harder to maintain than using structpb.NewStruct. Using structpb.NewStruct with a map is the idiomatic way to create these structures in Go and significantly improves readability. Additionally, the ips field was removed in this version; if it is required for the CONFIGURABLE_BAD_IP type, it should be included. When wrapping errors with fmt.Errorf, use the %w verb instead of %v to preserve the original error for inspection by callers.

Suggested change

	customModule := &securitycentermanagementpb.EventThreatDetectionCustomModule{
	Config: configStruct,
	//Replace with desired Display Name.
	Config: &structpb.Struct{
	Fields: map[string]*structpb.Value{
	"metadata": structpb.NewStructValue(&structpb.Struct{
	Fields: map[string]*structpb.Value{
	"description": structpb.NewStringValue("Sample custom module description"),
	"severity": structpb.NewStringValue("HIGH"),
	"recommendation": structpb.NewStringValue("Sample recommendation"),
	},
	}),
	"complianceStatus": structpb.NewStringValue("COMPLIANT"),
	},
	},
	DisplayName: displayName,
	EnablementState: securitycentermanagementpb.EventThreatDetectionCustomModule_ENABLED,
	Type: "CONFIGURABLE_BAD_IP",
	}
	config, err := structpb.NewStruct(map[string]interface{}{
	"metadata": map[string]interface{}{
	"description": "Sample custom module description",
	"severity": "HIGH",
	"recommendation": "Sample recommendation",
	},
	"complianceStatus": "COMPLIANT",
	})
	if err != nil {
	return "", fmt.Errorf("structpb.NewStruct: %w", err)
	}
	customModule := &securitycentermanagementpb.EventThreatDetectionCustomModule{
	Config: config,
	DisplayName: displayName,
	EnablementState: securitycentermanagementpb.EventThreatDetectionCustomModule_ENABLED,
	Type: "CONFIGURABLE_BAD_IP",
	}

References

1. In Go, when wrapping errors with fmt.Errorf, use the %w verb instead of %v to preserve the original error for inspection by callers.