refactor: replace legacy gsutil calls with gcloud#5530
refactor: replace legacy gsutil calls with gcloud#5530amcolin wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces gsutil commands with gcloud storage across several deployment and testing scripts. Feedback includes correcting the ACL flag format in the Makefile from publicRead to public-read and addressing potential compatibility issues with the Google Cloud SDK version on legacy Debian images.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates storage operations from gsutil to gcloud storage across several scripts and configuration files, while also updating the GCE deployment to use Debian 12 and an E2-series machine type. The review identifies a critical compatibility issue where the legacy google-fluentd agent in the startup script is unsupported on Debian 12. Additionally, it is recommended to include the --quiet flag in gcloud commands within scripts and Makefiles to ensure non-interactive execution and prevent automated processes from hanging.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates storage operations from gsutil to gcloud storage across deployment scripts, CI configurations, and Makefiles, while also updating GCE instance images to Debian 11 and machine types to e2-small. The review feedback identifies that the -q flag is incorrectly used with the gcloud storage cp command, which will cause execution failures in the deployment scripts and Makefile.
|
LGTM |
3 participants
Description
Updated scripts to use
gcloud storagecommands instead of the legacygsutiltool. This aligns with the current Google Cloud recommendations for improved performance and unified authentication.Fixes Internal b/498645997
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)