Skip to content

fix(wip): update cloud run markdown sample from cjs to esm 🚧#3592

Closed
pattishin wants to merge 9 commits intomainfrom
fix/update-markdown-preview-esm
Closed

fix(wip): update cloud run markdown sample from cjs to esm 🚧#3592
pattishin wants to merge 9 commits intomainfrom
fix/update-markdown-preview-esm

Conversation

@pattishin
Copy link
Copy Markdown
Contributor

@pattishin pattishin commented Dec 15, 2023 •
edited
Loading

Description

Fixes b-253601199

Ref: sindresorhus/got#1257

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin pattishin requested review from a team as code owners December 15, 2023 04:53
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Dec 15, 2023
@pattishin
Copy link
Copy Markdown
Contributor Author

pattishin commented Dec 15, 2023

Checking out failed kokoro tests 👍🏼

@pattishin pattishin added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 15, 2023
@pattishin pattishin changed the title fix: update cloud run markdown sample from cjs to esm fix: update cloud run markdown sample from cjs to esm 🚧 Dec 15, 2023
@pattishin pattishin force-pushed the fix/update-markdown-preview-esm branch from 1874428 to 0129958 Compare December 21, 2023 01:26
@pattishin
Copy link
Copy Markdown
Contributor Author

pattishin commented Dec 21, 2023

Update: Requires node 20 image to pass CI. More information added to task.

@pattishin pattishin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 21, 2023
@pattishin pattishin changed the title fix: update cloud run markdown sample from cjs to esm 🚧 fix(wip): update cloud run markdown sample from cjs to esm 🚧 Dec 21, 2023
@grayside grayside marked this pull request as draft January 8, 2024 19:02
@glasnt glasnt removed their assignment Jan 18, 2024
@glasnt glasnt mentioned this pull request Jan 22, 2024
Merged
4 tasks
@pattishin pattishin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 8, 2024
@pattishin pattishin closed this Apr 24, 2024
@pattishin pattishin deleted the fix/update-markdown-preview-esm branch April 24, 2024 18:50
@iennae iennae restored the fix/update-markdown-preview-esm branch March 25, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pattishin @glasnt @iennae