Skip to content

ci(knex): migrate to new ci#4010

Closed
glasnt wants to merge 2 commits intomainfrom
ci-knex
Closed

ci(knex): migrate to new ci#4010
glasnt wants to merge 2 commits intomainfrom
ci-knex

Conversation

@glasnt
Copy link
Copy Markdown
Contributor

@glasnt glasnt commented Mar 4, 2025

Description

Testing patterns for cloud sql proxy tests

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: cloudsql Issues related to the Cloud SQL for MySQL API. asset: pattern DEE Asset tagging - Pattern. labels Mar 4, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting /gemini summary.

@glasnt
Copy link
Copy Markdown
Contributor Author

glasnt commented Mar 4, 2025

This PR is blocked on SQL connection permissions

@glasnt
Copy link
Copy Markdown
Contributor Author

glasnt commented Mar 24, 2025

Closing until #3985 (comment) resolved

@glasnt glasnt closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql Issues related to the Cloud SQL for MySQL API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant