Skip to content

chore(compute): Migrate region tag #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 5 commits into from
Apr 2, 2025
Merged

chore(compute): Migrate region tag #4047

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0cfbb5
chore(compute): Migrate region tag
hivanalejandro Mar 27, 2025
b9bfcaa
chore(compute): Rename region tag
hivanalejandro Mar 27, 2025
017754a
Merge branch 'main' into hivanalejandro-migrate-region-step1-386956777
hivanalejandro Mar 28, 2025
4520d97
Merge branch 'main' into hivanalejandro-migrate-region-step1-386956777
hivanalejandro Mar 31, 2025
7a89ddd
Merge branch 'main' into hivanalejandro-migrate-region-step1-386956777
hivanalejandro Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compute/sendgrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

'use strict';

// [START compute_sendgrid_nodejs]
Copy link
Copy Markdown
Contributor

@eapl-gemugami eapl-gemugami Mar 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: As this file is Javascript source code, the language suffix SHOULD NOT be included in the region tag. See the internal naming guide for advice.
compute_sendgrid could be enough in this context.

Copy link
Copy Markdown
Contributor

@eapl-gemugami eapl-gemugami Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, check the internal issue for the description from the reporter. It specifies the requested region tag.

// [START compute_send]
// This sample is based off of:
// https://github.com/sendgrid/sendgrid-nodejs/tree/master/packages/mail
Expand All @@ -30,3 +31,4 @@ async function sendgridExample() {
}
sendgridExample();
// [END compute_send]
// [END compute_sendgrid_nodejs]
Loading