Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions parametermanager/createParam.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

/**
* Creates a global parameter using the Parameter Manager SDK.
*
* @param {string} projectId - The Google Cloud project ID where the parameter is to be created.
* @param {string} parameterId - The ID of the parameter to create. This ID must be unique within the project.
*/
async function main(projectId = 'my-project', parameterId = 'my-parameter') {
Comment thread
glasnt marked this conversation as resolved.
Outdated
// [START parametermanager_create_param]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const projectId = 'YOUR_PROJECT_ID';
// const parameterId = 'YOUR_PARAMETER_ID';
Comment on lines +26 to +29
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider providing a mechanism for users to pass the projectId and parameterId values as command-line arguments or environment variables instead of relying on them to uncomment these lines. This would make the sample more flexible and easier to use.


// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');

// Instantiates a client
const client = new ParameterManagerClient();

async function createParam() {
const parent = client.locationPath(projectId, 'global');
const request = {
parent: parent,
parameterId: parameterId,
};

const [parameter] = await client.createParameter(request);
console.log(`Created parameter: ${parameter.name}`);
}

await createParam();
// [END parametermanager_create_param]
}

const args = process.argv.slice(2);
main(...args).catch(console.error);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this .catch will catch errors, it doesn't provide specific feedback to the user about what went wrong. Consider adding more robust error handling within the main function to provide more informative error messages.

Suggested change
main(...args).catch(console.error);
main(...args).catch(err => {
console.error('ERROR:', err);
process.exitCode = 1; // Exit with a non-zero status code to indicate failure
});

75 changes: 75 additions & 0 deletions parametermanager/createParamVersion.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

/**
* Creates a parameter version globally for unstructured data.
*
* @param {string} projectId - The Google Cloud project ID where the parameter is to be created
* @param {string} parameterId - The ID of the parameter for which the version is to be created.
* @param {string} parameterVersionId - The ID of the parameter version to be created.
* @param {string} payload - The unformatted string payload to be stored in the new parameter version.
*/
async function main(
projectId = 'my-project',
parameterId = 'my-parameter',
parameterVersionId = 'v1',
payload = 'This is unstructured data'
) {
// [START parametermanager_create_param_version]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const projectId = 'YOUR_PROJECT_ID';
// const parameterId = 'YOUR_PARAMETER_ID';
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID';
// const payload = 'This is unstructured data';
Comment on lines +28 to +33
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider providing a mechanism for users to pass the projectId, parameterId, parameterVersionId, and payload values as command-line arguments or environment variables instead of relying on them to uncomment these lines. This would make the sample more flexible and easier to use.


// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');

// Instantiates a client
const client = new ParameterManagerClient();

async function createParamVersion() {
// Construct the parent resource name
const parent = client.parameterPath(projectId, 'global', parameterId);

// Construct the parameter version
const parameterVersion = {
payload: {
data: Buffer.from(payload, 'utf8'),
},
};

// Construct the request
const request = {
parent: parent,
parameterVersionId: parameterVersionId,
parameterVersion: parameterVersion,
};

// Create the parameter version
const [response] = await client.createParameterVersion(request);
console.log(`Created parameter version: ${response.name}`);
}

await createParamVersion();
// [END parametermanager_create_param_version]
}

// Parse command line arguments
const args = process.argv.slice(2);
main(...args).catch(console.error);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this .catch will catch errors, it doesn't provide specific feedback to the user about what went wrong. Consider adding more robust error handling within the main function to provide more informative error messages.

Suggested change
main(...args).catch(console.error);
main(...args).catch(err => {
console.error('ERROR:', err);
process.exitCode = 1; // Exit with a non-zero status code to indicate failure
});

85 changes: 85 additions & 0 deletions parametermanager/createParamVersionWithSecret.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

/**
* Creates a new version of an existing parameter in the global location
* of the specified project using the Google Cloud Parameter Manager SDK.
* The payload is specified as a JSON string and includes a reference to a secret.
*
* @param {string} projectId - The Google Cloud project ID where the parameter is located.
* @param {string} parameterId - The ID of the parameter for which the version is to be created.
* @param {string} parameterVersionId - The ID of the parameter version to be created.
* @param {string} secretId - The ID of the secret to be referenced.
*/
async function main(
projectId = 'my-project',
parameterId = 'my-parameter',
parameterVersionId = 'v1',
secretId = 'projects/my-project/secrets/application-secret/version/latest'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The parameterVersionId is hardcoded as 'v1' in the function definition but is passed as a command-line argument. This inconsistency could lead to confusion. It would be better to either use the command-line argument value as the default or remove the default value from the function definition.

parameterVersionId

) {
// [START parametermanager_create_param_version_with_secret]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const projectId = 'YOUR_PROJECT_ID';
// const parameterId = 'YOUR_PARAMETER_ID';
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID';
// const secretId = 'YOUR_SECRET_ID'; // For example projects/my-project/secrets/application-secret/version/latest
Comment on lines +30 to +35
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider providing a mechanism for users to pass the projectId, parameterId, parameterVersionId, and secretId values as command-line arguments or environment variables instead of relying on them to uncomment these lines. This would make the sample more flexible and easier to use.


// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');

// Instantiates a client
const client = new ParameterManagerClient();

async function createParamVersionWithSecret() {
// Construct the parent resource name
const parent = client.parameterPath(projectId, 'global', parameterId);

// Construct the JSON data with secret references
const jsonData = {
db_user: 'test_user',
db_password: `__REF__(//secretmanager.googleapis.com/${secretId})`,
};

// Construct the parameter version
const parameterVersion = {
payload: {
data: Buffer.from(JSON.stringify(jsonData), 'utf8'),
},
};

// Construct the request
const request = {
parent: parent,
parameterVersionId: parameterVersionId,
parameterVersion: parameterVersion,
};

// Create the parameter version
const [response] = await client.createParameterVersion(request);
console.log(
`Created parameter version with secret references: ${response.name}`
);
}

await createParamVersionWithSecret();
// [END parametermanager_create_param_version_with_secret]
}

// Parse command line arguments
const args = process.argv.slice(2);
main(...args).catch(console.error);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this .catch will catch errors, it doesn't provide specific feedback to the user about what went wrong. Consider adding more robust error handling within the main function to provide more informative error messages.

main(...args).catch(err => {
  console.error('ERROR:', err);
  process.exitCode = 1; // Exit with a non-zero status code to indicate failure
});

69 changes: 69 additions & 0 deletions parametermanager/createStructuredParam.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

const {protos} = require('@google-cloud/parametermanager');

/**
* Creates a parameter in the global location of the specified
* project with specified format using the Google Cloud Parameter Manager SDK.
*
* @param {string} projectId - The Google Cloud project ID where the parameter is to be created.
* @param {string} parameterId - The ID of the parameter to create. This ID must be unique within the project.
* @param {string} formatType - The format type of the parameter (UNFORMATTED, YAML, JSON).
*/
async function main(
projectId = 'my-project',
parameterId = 'my-json-parameter',
formatType = protos.google.cloud.parametermanager.v1.ParameterFormat.JSON
) {
// [START parametermanager_create_structured_param]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const {protos} = require('@google-cloud/parametermanager');
// const projectId = 'YOUR_PROJECT_ID';
// const parameterId = 'YOUR_PARAMETER_ID';
// const formatType = protos.google.cloud.parametermanager.v1.ParameterFormat.JSON;
Comment on lines +28 to +33
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider providing a mechanism for users to pass the projectId, parameterId, and formatType values as command-line arguments or environment variables instead of relying on them to uncomment these lines. This would make the sample more flexible and easier to use.


// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');

// Instantiates a client
const client = new ParameterManagerClient();

async function createStructuredParam() {
const parent = client.locationPath(projectId, 'global');
const request = {
parent: parent,
parameterId: parameterId,
parameter: {
format: formatType,
},
};

const [parameter] = await client.createParameter(request);
console.log(
`Created parameter ${parameter.name} with format ${parameter.format}`
);
}

await createStructuredParam();
// [END parametermanager_create_structured_param]
}

// This sample demonstrates how to create a parameter for structured data of JSON type.
const args = process.argv.slice(2);
main(...args).catch(console.error);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this .catch will catch errors, it doesn't provide specific feedback to the user about what went wrong. Consider adding more robust error handling within the main function to provide more informative error messages.

Suggested change
main(...args).catch(console.error);
main(...args).catch(err => {
console.error('ERROR:', err);
process.exitCode = 1; // Exit with a non-zero status code to indicate failure
});

77 changes: 77 additions & 0 deletions parametermanager/createStructuredParamVersion.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

/**
* Creates a new version of an existing parameter in the global location
* of the specified project using the Google Cloud Parameter Manager SDK.
* The payload is specified as a JSON format.
*
* @param {string} projectId - The Google Cloud project ID where the parameter is to be created.
* @param {string} parameterId - The ID of the parameter to create. This ID must be unique within the project.
* @param {string} parameterVersionId - The ID of the parameter version to be created.
* @param {Object} payload - The JSON payload data to be stored in the parameter version.
*/
async function main(
projectId = 'my-project',
parameterId = 'my-parameter',
parameterVersionId = 'v1',
payload = {username: 'test-user', host: 'localhost'}
) {
// [START parametermanager_create_structured_param_version]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const projectId = 'YOUR_PROJECT_ID';
// const parameterId = 'YOUR_PARAMETER_ID';
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID';
// const jsonData = {username: "test-user", host: "localhost"};
Comment on lines +30 to +35
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider providing a mechanism for users to pass the projectId, parameterId, parameterVersionId, and payload values as command-line arguments or environment variables instead of relying on them to uncomment these lines. This would make the sample more flexible and easier to use.


// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');

// Instantiates a client
const client = new ParameterManagerClient();

async function createStructuredParamVersion() {
// Construct the parent resource name
const parent = client.parameterPath(projectId, 'global', parameterId);

// Construct the parameter version
const parameterVersion = {
payload: {
data: Buffer.from(JSON.stringify(payload), 'utf8'),
},
};

// Construct the request
const request = {
parent: parent,
parameterVersionId: parameterVersionId,
parameterVersion: parameterVersion,
};

// Create the parameter version
const [response] = await client.createParameterVersion(request);
console.log(`Created parameter version: ${response.name}`);
}

await createStructuredParamVersion();
// [END parametermanager_create_structured_param_version]
}

// Parse command line arguments
const args = process.argv.slice(2);
main(...args).catch(console.error);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this .catch will catch errors, it doesn't provide specific feedback to the user about what went wrong. Consider adding more robust error handling within the main function to provide more informative error messages.

Suggested change
main(...args).catch(console.error);
main(...args).catch(err => {
console.error('ERROR:', err);
process.exitCode = 1; // Exit with a non-zero status code to indicate failure
});

Loading