Skip to content

fix: auth on forked repos #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidcavazos merged 3 commits into from
May 12, 2025
Merged

fix: auth on forked repos #4087

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3dd96a
fix: support tests on forked repos
May 12, 2025
00f2e48
checkout and auth as separate steps
May 12, 2025
202bfad
remove changes to packages to trigger tests
May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/custard-run-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,25 @@ jobs:
name: (experimental / dev) Custard CI / ${{ github.job }} (${{ matrix.path }})
job-name: ${{ github.job }} (${{ matrix.path }})
if: ${{ !!github.event.workflow_run }}
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- name: Authenticate
uses: google-github-actions/auth@ba79af03959ebeac9769e648f473a284504d9193 # v2.1.10
id: auth
with:
project_id: ${{ env.GOOGLE_SAMPLES_PROJECT }}
workload_identity_provider: projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider
service_account: ${{ env.GOOGLE_SERVICE_ACCOUNT }}
access_token_lifetime: 600s # 10 minutes
token_format: id_token
id_token_audience: https://action.test/ # service must have this custom audience
id_token_include_email: true
- name: Setup Custard
uses: GoogleCloudPlatform/cloud-samples-tools/actions/steps/setup-custard@9ee708234e240605d96e78f652c333ed6aa95a23 # v0.3.2
with:
path: ${{ matrix.path }}
ci-setup: ${{ toJson(fromJson(needs.affected.outputs.ci-setups)[matrix.path]) }}
project-id: ${{ env.GOOGLE_SAMPLES_PROJECT }}
workload-identity-provider: projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider
service-account: ${{ env.GOOGLE_SERVICE_ACCOUNT }}
id-token: ${{ steps.auth.outputs.id_token }}
- name: Check in_progress
uses: GoogleCloudPlatform/cloud-samples-tools/actions/steps/update-check@9ee708234e240605d96e78f652c333ed6aa95a23 # v0.3.2
id: in_progress
Expand Down
17 changes: 14 additions & 3 deletions .github/workflows/custard-run.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,25 @@ jobs:
name: (experimental) Custard CI / ${{ github.job }} (${{ matrix.path }})
job-name: ${{ github.job }} (${{ matrix.path }})
if: ${{ !!github.event.workflow_run }}
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- name: Authenticate
uses: google-github-actions/auth@ba79af03959ebeac9769e648f473a284504d9193 # v2.1.10
id: auth
with:
project_id: ${{ env.GOOGLE_SAMPLES_PROJECT }}
workload_identity_provider: projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider
service_account: ${{ env.GOOGLE_SERVICE_ACCOUNT }}
access_token_lifetime: 600s # 10 minutes
token_format: id_token
id_token_audience: https://action.test/ # service must have this custom audience
id_token_include_email: true
- name: Setup Custard
uses: GoogleCloudPlatform/cloud-samples-tools/actions/steps/setup-custard@9ee708234e240605d96e78f652c333ed6aa95a23 # v0.3.2
with:
path: ${{ matrix.path }}
ci-setup: ${{ toJson(fromJson(needs.affected.outputs.ci-setups)[matrix.path]) }}
project-id: ${{ env.GOOGLE_SAMPLES_PROJECT }}
workload-identity-provider: projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider
service-account: ${{ env.GOOGLE_SERVICE_ACCOUNT }}
id-token: ${{ steps.auth.outputs.id_token }}
- name: Check in_progress
uses: GoogleCloudPlatform/cloud-samples-tools/actions/steps/update-check@9ee708234e240605d96e78f652c333ed6aa95a23 # v0.3.2
id: in_progress
Expand Down
2 changes: 2 additions & 0 deletions run/helloworld/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO: remove this comment, used to trigger tests

// [START cloudrun_helloworld_service]
import express from 'express';
const app = express();
Expand Down
2 changes: 2 additions & 0 deletions tpu/createVM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

// TODO: remove this comment, used to trigger tests

'use strict';

async function main(tpuClient) {
Expand Down
Loading