Skip to content

fix: rename service account env var#4089

Merged
davidcavazos merged 1 commit intomainfrom
custard-service-account
May 12, 2025
Merged

fix: rename service account env var#4089
davidcavazos merged 1 commit intomainfrom
custard-service-account

Conversation

@davidcavazos
Copy link
Copy Markdown

Description

Cloud Run tests expect the service account variable be named SERVICE_ACCOUNT. The setup-custard action doesn't include an input to pass and re-export the variable, but that will go away with the self-contained runner. Renaming it to SERVICE_ACCOUNT is also what the self-contained runner expects.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 12, 2025
@davidcavazos davidcavazos marked this pull request as ready for review May 12, 2025 20:39
@product-auto-label product-auto-label Bot added the api: workflows Issues related to the Workflows API. label May 12, 2025
@davidcavazos davidcavazos requested review from a team as code owners May 12, 2025 20:39
@davidcavazos davidcavazos merged commit 892d203 into main May 12, 2025
14 checks passed
@davidcavazos davidcavazos deleted the custard-service-account branch May 12, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants