fix: pass service account directly to run step#4090
Merged
Conversation
added 3 commits
May 12, 2025 13:37
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
glasnt
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It turns out that
setup-custardoverrides and clears up the SERVICE_ACCOUNT variable.Even though the input is referenced, it's not defined and can't be passed.
This will no longer be an issue when GoogleCloudPlatform/cloud-samples-tools#49 merges, and it will handle the environment variables as expected.
Once that merges, we can get rid of the
setup-custardaction altogether.Instead of going through the whole cycle of fixing that action and releasing a new version, we pass the SERVICE_ACCOUNT directly to the step running the tests as a workaround.
This can go away once we use the TS runner.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.