Skip to content

fix: pass service account directly to run step#4090

Merged
glasnt merged 3 commits intomainfrom
custard-service-account
May 12, 2025
Merged

fix: pass service account directly to run step#4090
glasnt merged 3 commits intomainfrom
custard-service-account

Conversation

@davidcavazos
Copy link
Copy Markdown

@davidcavazos davidcavazos commented May 12, 2025

Description

It turns out that setup-custard overrides and clears up the SERVICE_ACCOUNT variable.
Even though the input is referenced, it's not defined and can't be passed.

This will no longer be an issue when GoogleCloudPlatform/cloud-samples-tools#49 merges, and it will handle the environment variables as expected.

Once that merges, we can get rid of the setup-custard action altogether.
Instead of going through the whole cycle of fixing that action and releasing a new version, we pass the SERVICE_ACCOUNT directly to the step running the tests as a workaround.
This can go away once we use the TS runner.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 12, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@product-auto-label product-auto-label Bot added the api: workflows Issues related to the Workflows API. label May 12, 2025
@davidcavazos davidcavazos marked this pull request as ready for review May 12, 2025 21:06
@davidcavazos davidcavazos requested review from a team as code owners May 12, 2025 21:06
@glasnt glasnt merged commit edf7782 into main May 12, 2025
14 checks passed
@glasnt glasnt deleted the custard-service-account branch May 12, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants