Skip to content

chore(modelarmor): enabled floor settings tests #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 10 commits into from
Aug 12, 2025
Merged

chore(modelarmor): enabled floor settings tests #4123

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
147ae83
chore(tests): enabled floor settings tests
mihirvala08 Jul 3, 2025
604d268
chore(tests): added floor setting enable flag exists on get tests
mihirvala08 Jul 8, 2025
c3dacf1
chore(tests): enabled floor settings clean-up
mihirvala08 Jul 8, 2025
97d9dd5
Merge branch 'GoogleCloudPlatform:main' into model-armor-enable-floor…
harshnasitcrest Jul 29, 2025
7c0c0f7
Merge branch 'main' into model-armor-enable-floor-settings-tests
glasnt Aug 1, 2025
a37a29f
Merge branch 'main' into model-armor-enable-floor-settings-tests
harshnasitcrest Aug 4, 2025
90d8b32
removed empty template related tests
harshnasitcrest Aug 5, 2025
f2bdb73
chore: update dependencies and improve floor settings tests
harshnasitcrest Aug 11, 2025
3a770cf
ci: move custard config to same level as package.json
glasnt Aug 12, 2025
ddcc5de
ci: may not support ints here, use strings
glasnt Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions model-armor/test/modelarmor.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,9 +940,7 @@ describe('Model Armor tests', () => {

// =================== Floor Settings Tests ===================

// TODO(b/424365799): Enable below tests once the mentioned issue is resolved

it.skip('should get organization floor settings', async () => {
it('should get organization floor settings', async () => {
Comment thread
mihirvala08 marked this conversation as resolved.
const getOrganizationFloorSettings = require('../snippets/getOrganizationFloorSettings');

const output = await getOrganizationFloorSettings.main(organizationId);
Expand All @@ -951,7 +949,7 @@ describe('Model Armor tests', () => {
assert.equal(output.name, expectedName);
});

it.skip('should get folder floor settings', async () => {
it('should get folder floor settings', async () => {
const getFolderFloorSettings = require('../snippets/getFolderFloorSettings');

const output = await getFolderFloorSettings.main(folderId);
Expand All @@ -961,7 +959,7 @@ describe('Model Armor tests', () => {
assert.equal(output.name, expectedName);
});

it.skip('should get project floor settings', async () => {
it('should get project floor settings', async () => {
const getProjectFloorSettings = require('../snippets/getProjectFloorSettings');

const output = await getProjectFloorSettings.main(projectId);
Expand All @@ -970,21 +968,21 @@ describe('Model Armor tests', () => {
assert.equal(output.name, expectedName);
});

it.skip('should update organization floor settings', async () => {
it('should update organization floor settings', async () => {
Comment thread
mihirvala08 marked this conversation as resolved.
Outdated
const updateOrganizationFloorSettings = require('../snippets/updateOrganizationFloorSettings');
const output = await updateOrganizationFloorSettings.main(organizationId);
// Check that the enableFloorSettingEnforcement=true
assert.equal(output.enableFloorSettingEnforcement, true);
});

it.skip('should update folder floor settings', async () => {
it('should update folder floor settings', async () => {
const updateFolderFloorSettings = require('../snippets/updateFolderFloorSettings');
const output = await updateFolderFloorSettings.main(folderId);
// Check that the enableFloorSettingEnforcement=true
assert.equal(output.enableFloorSettingEnforcement, true);
});

it.skip('should update project floor settings', async () => {
it('should update project floor settings', async () => {
const updateProjectFloorSettings = require('../snippets/updateProjectFloorSettings');
const output = await updateProjectFloorSettings.main(projectId);
// Check that the enableFloorSettingEnforcement=true
Expand Down
Loading