Skip to content

fix(retail): add region tag for node.js - Update rejoin user events #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 13 commits into from
Jul 15, 2025
Merged

fix(retail): add region tag for node.js - Update rejoin user events #4130

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bf9bdd0
Update search-simple-query.js
rebeccaellis Jun 10, 2025
4248f5c
Merge pull request #1 from rebeccaellis/rebeccaellis-patch-1
rebeccaellis Jun 10, 2025
79c293e
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 10, 2025
ec27aa3
Update search-with-pagination.js
rebeccaellis Jun 10, 2025
521dafa
Merge pull request #2 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis Jun 11, 2025
bb3d2dc
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 12, 2025
d26b14b
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 17, 2025
d214b97
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 18, 2025
0516da1
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 27, 2025
9ba45d9
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jul 8, 2025
efc86ce
Update rejoin-user-events.js
rebeccaellis Jul 8, 2025
9b0e52c
Merge branch 'main' into rebeccaellis-rejoin-user-events
glasnt Jul 11, 2025
f3e3021
Merge branch 'main' into rebeccaellis-rejoin-user-events
glasnt Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions retail/interactive-tutorials/events/rejoin-user-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// [START retail_rejoin_user_events]
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

By adding region tags, this code snippet is now likely to be used in documentation, so it's important to ensure it follows best practices and is free of bugs. I've noticed a couple of issues in the enclosed code:

  • Missing await: The call to utils.purgeUserEvents(parent, visitorId) on line 67 is not awaited. purgeUserEvents is an async function, and without await, the main function might complete and the script exit before the purge operation is sent to the server. This would cause the cleanup step to fail silently, leaving test data behind. The fix is to change the line to await utils.purgeUserEvents(parent, visitorId);.

  • Hardcoded Enum: The UserEventRejoinScope enum is defined locally on lines 32-36. It's better practice to use the enum provided by the @google-cloud/retail client library, if it's exported. Using the library's enum makes the code more robust against future API changes.

Since I cannot comment directly on the affected lines (67 and 32-36) due to tooling limitations, I'm leaving this comment here on the start of the region tag. Please address these issues to improve the quality of this code sample.


'use strict';

Expand Down Expand Up @@ -72,3 +73,5 @@ process.on('unhandledRejection', err => {
});

main();

// [END retail_rejoin_user_events]
Loading