Skip to content

feat(genai): Sample/textgen part3#4170

Merged
msampathkumar merged 7 commits intoGoogleCloudPlatform:mainfrom
Guiners:sample/textgen-part3
Sep 2, 2025
Merged

feat(genai): Sample/textgen part3#4170
msampathkumar merged 7 commits intoGoogleCloudPlatform:mainfrom
Guiners:sample/textgen-part3

Conversation

@Guiners
Copy link
Copy Markdown
Contributor

@Guiners Guiners commented Aug 25, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners August 25, 2025 12:50
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 25, 2025
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Aug 25, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new Node.js samples for Google Cloud's Generative AI, specifically focusing on advanced text generation capabilities. It adds examples for generating text from PDF documents and from multiple local image inputs, demonstrating how to interact with the Gemini model for these tasks.

Highlights

  • New Text Generation Sample (PDF): Introduces a new sample (textgen-code-with-pdf.js) demonstrating how to generate text content from a PDF file using the Gemini model.
  • New Text Generation Sample (Multi-Image): Adds a new sample (textgen-with-multi-local-img.js) showcasing text generation from multiple local image inputs, converting images to base64 for API calls.
  • Corresponding Tests: Includes new test files (textgen-code-with-pdf.test.js and textgen-with-multi-local-img.test.js) to validate the functionality of the newly added text generation samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new GenAI samples for text generation, one using a PDF and another with multiple local images, along with their corresponding tests. The sample code is well-structured. I've identified a couple of minor issues in the test files, including an incorrect test description and unnecessary async keywords on describe blocks, which should be addressed to improve code quality and clarity.

Comment thread genai/test/textgen-code-with-pdf.test.js Outdated
Comment thread genai/test/textgen-with-multi-local-img.test.js Outdated
Comment thread genai/test/textgen-with-multi-local-img.test.js Outdated
Copy link
Copy Markdown
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar msampathkumar merged commit 40758cc into GoogleCloudPlatform:main Sep 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants