feature(appengine): Update quickstart samples to Nodejs24#4192
feature(appengine): Update quickstart samples to Nodejs24#4192iennae merged 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello @srinjoyray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares several quickstart samples for the upcoming General Availability (GA) of Node.js 24 across various Google Cloud services. The changes primarily involve updating runtime and engine configurations to Node.js 24 and Ubuntu 24, ensuring the samples are compatible with the latest environments. Additionally, a .gcloudignore file is introduced to optimize deployments by preventing unnecessary files from being uploaded. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js runtime to version 24 for the appengine/building-an-app/build and appengine/hello-world/flexible quickstart samples. The changes are correct and align with the goal of migrating to Node.js 24. I have one minor suggestion to add a final newline to the new .gcloudignore file. Additionally, I noticed that other quickstart samples like appengine/building-an-app/update and appengine/hello-world/standard are still configured for Node.js 20. To maintain consistency, you might consider updating these samples as well in this or a subsequent pull request.
iennae
left a comment
There was a problem hiding this comment.
the only failure is due to genai samples issues unrelated to this change
Description
Nodejs 24 is going to GA for GAE Standard, Flex, GCF, Cloud Run and CRF.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.