Skip to content

ci(genai): Update genai directory to run tests in specific directories only#4203

Merged
holtskinner merged 10 commits intomainfrom
build/genai-workflow
Dec 18, 2025
Merged

ci(genai): Update genai directory to run tests in specific directories only#4203
holtskinner merged 10 commits intomainfrom
build/genai-workflow

Conversation

@holtskinner
Copy link
Copy Markdown
Contributor

@holtskinner holtskinner commented Dec 18, 2025

PRs for the Gen AI SDK have been blocked due to test timeout failures due to all of the tests in the full repo running for every PR. This adds dedicated testing directories to prevent this issue.

Follows similar pattern to functions/ directory

Moves genai testing from the shared custard-ci workflow to a dedicated workflow file. This ensures tests only run when files in genai/ change, and allows for better isolation.
@holtskinner holtskinner requested review from a team as code owners December 18, 2025 16:41
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Dec 18, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a standalone continuous integration workflow for genai related tests. This strategic separation aims to enhance the efficiency of the testing process by ensuring that genai tests are only triggered when relevant files are altered, thereby improving test isolation and reducing unnecessary build times.

Highlights

  • Dedicated CI Workflow for GenAI: A new, dedicated CI workflow has been created specifically for genai tests, moving them out of the shared custard-ci workflow.
  • Improved Test Efficiency and Isolation: This change ensures that genai tests will only execute when files within the genai/ directory are modified, leading to more efficient test runs and better isolation of the testing environment.
  • Configuration Update: The .github/config/nodejs.jsonc file has been updated to explicitly exclude the genai directory from the general Node.js CI configuration, as it now has its own dedicated workflow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/genai.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to create a dedicated CI workflow for genai tests. While it correctly excludes the genai directory from the existing shared workflow in .github/config/nodejs.jsonc, it fails to include the new dedicated workflow file (.github/workflows/genai.yaml). As a result, merging this PR in its current state would disable all tests for the genai module. The missing workflow file must be added before this PR can be approved.

Comment thread .github/config/nodejs.jsonc Outdated
@holtskinner holtskinner changed the title ci: create dedicated workflow for genai tests ci: Update genai directory to run tests in specific directories only Dec 18, 2025
@holtskinner holtskinner changed the title ci: Update genai directory to run tests in specific directories only ci(genai): Update genai directory to run tests in specific directories only Dec 18, 2025
Copy link
Copy Markdown

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping for other reviewers.

@holtskinner holtskinner merged commit 9d1b80e into main Dec 18, 2025
45 checks passed
@holtskinner holtskinner deleted the build/genai-workflow branch December 18, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: genai api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants