fix(vision): Improve logo detection#4209
Conversation
Summary of ChangesHello @amcolin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Node.js Google Cloud Vision API samples by transitioning the logo detection functionality from a single-feature convenience method to the more robust "batchAnnotateImages" API. This change ensures consistency with other Google Cloud client libraries, which are deprecating single-feature methods, and promotes a "batch-first" approach for improved performance and scalability in real-world applications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request refactors the detectLogos and detectLogosGCS functions in vision/detect.js to use the client.batchAnnotateImages method instead of the deprecated client.logoDetection method. For local file detection, the fs module is now imported to read the image file and convert it to a base64 string for the API request. Both functions now construct a detailed request object for batch annotation, specifying the image source and the LOGO_DETECTION feature. The response handling has also been updated to iterate through the batch responses, logging logo annotations and explicitly handling potential errors for each response.
Description
Refactors Vision samples to use batchAnnotateImages instead of the high-level logoDetection method.
Why this is important:
To align the Node.js samples with Google Cloud’s Java, Go, and Python libraries, where single-feature convenience methods are being deprecated or discouraged.
To demonstrates the recommended "batch-first" architecture, which is the standard for real-world applications requiring high throughput.
Internal: b/470281106
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.