chore(genai): Update live-audio-with-txt to use gemini-live-2.5-flash-native-audio#4221
Conversation
Summary of ChangesHello @angelcaamal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the model ID in live-audio-with-txt.js to gemini-live-2.5-flash-native-audio. While the change itself is correct, it creates an inconsistency with other related samples in the repository that still use the older model. I have added a review comment to suggest updating the model in other relevant files to maintain consistency across the samples.
|
|
||
| const voiceName = 'Aoede'; | ||
| const modelId = 'gemini-2.0-flash-live-preview-04-09'; | ||
| const modelId = 'gemini-live-2.5-flash-native-audio'; |
There was a problem hiding this comment.
While updating the model to gemini-live-2.5-flash-native-audio here is a good step, it introduces an inconsistency with other related samples. Specifically, live-conversation-audio-with-audio.js also generates audio but continues to use the older 'gemini-2.0-flash-live-preview-04-09' model. For consistency and to ensure all relevant samples are up-to-date, please consider updating the model in other audio-generating samples in this directory as well.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.