fix(memorystore): Fix outdated nodejs example for Memorystore for Redis.

[craig08]

Description

Fixes #4225

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• Required CI tests pass (see CI testing)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

[gemini-code-assist]

Summary of Changes

Hello @craig08, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the Node.js example for Google Cloud Memorystore for Redis by updating the node-redis client initialization and connection patterns, and refactoring asynchronous operations to use async/await. These changes ensure the example uses current best practices for Node.js and Redis integration, enhancing its reliability and maintainability.

Highlights

• Redis Client Modernization: The redis.createClient method was updated to use a URL string for configuration, and an explicit client.connect() call was added to establish the connection, aligning with the latest node-redis library practices.
• Asynchronous Code Refactoring: The client.incr operation within the HTTP server was refactored from a callback-based approach to use async/await, improving readability and error handling with a try-catch block.
• Server Startup Logging: A callback function was added to the http.createServer().listen() method to log a message indicating that the server has started and is listening on port 8080.

Changelog

• memorystore/redis/server.js
  • Updated redis.createClient to accept a URL string for Redis host and port.
  • Added explicit client.connect() call to establish the Redis connection.
  • Converted client.incr from callback-based to async/await syntax.
  • Implemented try-catch block for error handling in the HTTP request handler.
  • Added a callback to http.createServer().listen() to log server startup.

Activity

• The author has confirmed adherence to CONTRIBUTING.MD and Samples Style Guide.
• All local tests (npm test) and lint checks (npm run lint) have passed.
• The pull request originates from a direct branch off GoogleCloudPlatform/nodejs-docs-samples.
• The author has requested the PR to be merged upon approval.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the Memorystore for Redis Node.js example to use the modern redis v4 API, switching from callbacks to promises/async-await and using the new client creation and connection methods. This resolves the outdated usage. I've added one suggestion to improve the application's startup logic to prevent a race condition and handle Redis connection failures more robustly by ensuring the server only starts after a successful Redis connection.

[craig08]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the Memorystore for Redis Node.js example to be compatible with version 4 of the redis library. The changes correctly adopt the new Promise-based API, using async/await for cleaner asynchronous code. This also fixes a bug where the previous code used an incorrect method for setting the HTTP status code in error responses. The overall changes are a great improvement. I have one suggestion to make the application's startup failure behavior more explicit.