Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in getFhirStoreCapabilities.js#4236

Merged
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-store-capabilities
Feb 27, 2026
Merged

fix(healthcare): set responseType to JSON instead of Buffer in getFhirStoreCapabilities.js#4236
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-store-capabilities

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. api: healhcare labels Feb 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @angelcaamal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the Healthcare API client might not correctly parse responses by ensuring that the responseType is explicitly set to JSON. Additionally, it enhances the sample's reliability by introducing a try-catch block around the API call, providing better feedback in case of failures.

Highlights

  • API Client Configuration: The Google API client for the Healthcare API has been configured to explicitly request JSON responses by setting responseType: 'json'.
  • Error Handling: Robust error handling has been implemented around the getFhirStoreCapabilities API call, catching potential errors and logging them to the console.
Changelog
  • healthcare/fhir/getFhirStoreCapabilities.js
    • Added responseType: 'json' to the Google API client configuration.
    • Wrapped the getFhirStoreCapabilities API call in a try-catch block to handle potential errors gracefully.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue in getFhirStoreCapabilities.js by correctly setting the responseType to json for the healthcare API client. This ensures that the API response is parsed as a JSON object. The pull request also improves the script's reliability by adding a try...catch block to handle potential errors during the API call. My feedback includes a suggestion to further improve the error handling for this command-line script.

Comment thread healthcare/fhir/getFhirStoreCapabilities.js
@angelcaamal angelcaamal marked this pull request as ready for review February 26, 2026 20:01
@angelcaamal angelcaamal requested review from a team as code owners February 26, 2026 20:01
@iennae iennae merged commit 9d8a04c into GoogleCloudPlatform:main Feb 27, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healhcare api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants