Skip to content

fix(samples): Update comment for rendering latest parameter version#4286

Closed
sc-07 wants to merge 2 commits intomainfrom
latest-samples
Closed

fix(samples): Update comment for rendering latest parameter version#4286
sc-07 wants to merge 2 commits intomainfrom
latest-samples

Conversation

@sc-07
Copy link
Copy Markdown
Contributor

@sc-07 sc-07 commented Apr 16, 2026

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@sc-07 sc-07 requested review from a team as code owners April 16, 2026 07:21
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Apr 16, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sample code in renderRegionalParamVersion.js and renderParamVersion.js to indicate that parameterVersionId supports aliases. The review identifies that the current implementation introduces syntax errors if the lines are uncommented and suggests moving the explanation to a trailing comment.

Comment thread parametermanager/regional_samples/renderRegionalParamVersion.js
Comment thread parametermanager/renderParamVersion.js
@sc-07 sc-07 closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant