Skip to content

fix(samples): Update NodeJs comment for rendering latest parameter version #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cazad301197 merged 4 commits into from
Apr 16, 2026
Merged

fix(samples): Update NodeJs comment for rendering latest parameter version #4287

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d145c7c
fix(sample): Update comment for rendering latest parameter version
sc-07 Apr 16, 2026
39c2145
fix(sample): Update comment for rendering latest parameter version
sc-07 Apr 16, 2026
5533eeb
fix(samples):Update NodeJs comment for rendering latest parameter ver…
sc-07 Apr 16, 2026
80d5f69
fix lint issue
sc-07 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions parametermanager/regional_samples/renderRegionalParamVersion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* @param {string} projectId - The Google Cloud project ID where the parameter is located.
* @param {string} locationId - The ID of the region where parameter is located.
* @param {string} parameterId - The ID of the parameter for which version details are to be rendered.
* @param {string} parameterVersionId - The ID of the parameter version to be rendered.
* @param {string} parameterVersionId - The ID of the parameter version to be rendered or an alias (e.g. "latest").
Comment thread
sc-07 marked this conversation as resolved.
Outdated
*/
async function main(projectId, locationId, parameterId, parameterVersionId) {
// [START parametermanager_render_regional_param_version]
Expand All @@ -33,7 +33,8 @@
// const locationId = 'us-central1';
// const parameterId = 'YOUR_PARAMETER_ID';
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID';

// const parameterVersionId = 'latest';

Check failure on line 37 in parametermanager/regional_samples/renderRegionalParamVersion.js

View workflow job for this annotation

GitHub Actions / lint 

Trailing spaces not allowed

Check failure on line 37 in parametermanager/regional_samples/renderRegionalParamVersion.js

View workflow job for this annotation

GitHub Actions / lint 

Delete `··`
Comment thread
sc-07 marked this conversation as resolved.
Outdated
// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');

Expand Down
3 changes: 2 additions & 1 deletion parametermanager/renderParamVersion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*
* @param {string} projectId - The Google Cloud project ID where the parameter is located.
* @param {string} parameterId - The ID of the parameter for which version details are to be rendered.
* @param {string} parameterVersionId - The ID of the parameter version to be rendered.
* @param {string} parameterVersionId - The ID of the parameter version to be rendered or an alias (e.g. "latest").
Comment thread
sc-07 marked this conversation as resolved.
Outdated
*/
async function main(projectId, parameterId, parameterVersionId) {
// [START parametermanager_render_param_version]
Expand All @@ -31,6 +31,7 @@ async function main(projectId, parameterId, parameterVersionId) {
// const projectId = 'YOUR_PROJECT_ID';
// const parameterId = 'YOUR_PARAMETER_ID';
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID';
// const parameterVersionId = 'latest';

// Imports the Parameter Manager library
const {ParameterManagerClient} = require('@google-cloud/parametermanager');
Expand Down
Loading