Skip to content

feat: add workflow execution samples with and without arguments#4301

Closed
angelcaamal wants to merge 7 commits intomainfrom
feat/workflow-execution-samples
Closed

feat: add workflow execution samples with and without arguments#4301
angelcaamal wants to merge 7 commits intomainfrom
feat/workflow-execution-samples

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Apr 24, 2026

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Apr 24, 2026
@angelcaamal angelcaamal marked this pull request as ready for review April 24, 2026 19:15
@angelcaamal angelcaamal requested review from a team as code owners April 24, 2026 19:15
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 24, 2026

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Workflows quickstart samples and tests to improve execution consistency and configuration. It switches to using ts-node/register for test execution, updates package dependencies, and adds cleanup logic to tests to ensure workflows are deleted after execution. My feedback highlights that the current error handling in the test suite is too broad, as it swallows all exceptions instead of specifically checking for 'Not Found' errors, and points out that the ts-node/register hook is unnecessary when executing plain JavaScript files.

Comment thread workflows/quickstart/test/executeWorkflow.test.js
Comment thread workflows/quickstart/test/executeWorkflow.test.js Outdated
Comment thread workflows/quickstart/test/executeWorkflow.test.js Outdated
Comment thread workflows/quickstart/test/executeWorkflow.test.ts Outdated
Comment thread workflows/quickstart/test/quickstart.test.js Outdated
@angelcaamal angelcaamal force-pushed the feat/workflow-execution-samples branch from 4781830 to d6462ea Compare April 24, 2026 20:47
@angelcaamal angelcaamal deleted the feat/workflow-execution-samples branch April 24, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant