feat: add workflow execution samples with and without arguments#4301
feat: add workflow execution samples with and without arguments#4301angelcaamal wants to merge 7 commits intomainfrom
Conversation
Increased the timeout to account for the latency of workflow execution and polling.
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request updates the Workflows quickstart samples and tests to improve execution consistency and configuration. It switches to using ts-node/register for test execution, updates package dependencies, and adds cleanup logic to tests to ensure workflows are deleted after execution. My feedback highlights that the current error handling in the test suite is too broad, as it swallows all exceptions instead of specifically checking for 'Not Found' errors, and points out that the ts-node/register hook is unnecessary when executing plain JavaScript files.
4781830 to
d6462ea
Compare
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.