Skip to content

fix(ci): restrict workflow_run test jobs to same-repo runs only #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix(ci): restrict workflow_run test jobs to same-repo runs only #4303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/custard-run-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ jobs:
create-check-if: ${{ !!github.event.workflow_run }}

test:
if: needs.affected.outputs.paths != '[]'
# Guard: workflow_run fires for fork PRs but executes with repository secrets
# (id-token: write / GCP WIF). Restrict credential use to same-repo runs.
if: |
needs.affected.outputs.paths != '[]' &&
(github.event_name != 'workflow_run' || github.event.workflow_run.head_repository.full_name == github.repository)
needs: affected
runs-on: ubuntu-latest
timeout-minutes: 120 # 2 hours hard limit
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/custard-run.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ jobs:
status: failure

test:
if: needs.affected.outputs.paths != '[]'
# Guard: workflow_run fires for fork PRs but executes with repository secrets
# (id-token: write / GCP WIF). Restrict credential use to same-repo runs.
if: |
needs.affected.outputs.paths != '[]' &&
(github.event_name != 'workflow_run' || github.event.workflow_run.head_repository.full_name == github.repository)
needs: affected
runs-on: ubuntu-latest
timeout-minutes: 120 # 2 hours hard limit
Expand Down